Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(644)

Issue 105140047: code review 105140047: os: disable TestGetppid on plan9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by brainman
Modified:
5 years, 10 months ago
Reviewers:
gobot, dfc
CC:
golang-codereviews, dfc
Visibility:
Public.

Description

os: disable TestGetppid on plan9 Fixes build.

Patch Set 1 #

Patch Set 2 : diff -r 927f0508bc93 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 927f0508bc93 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 927f0508bc93 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/pkg/os/os_test.go View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
brainman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
5 years, 10 months ago (2014-06-14 06:39:50 UTC) #1
dfc
On 2014/06/14 06:39:50, brainman wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
5 years, 10 months ago (2014-06-14 06:47:12 UTC) #2
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=7d2e78c502ab *** os: disable TestGetppid on plan9 Fixes build. LGTM=dave R=golang-codereviews, dave ...
5 years, 10 months ago (2014-06-14 06:47:49 UTC) #3
gobot
5 years, 10 months ago (2014-06-14 07:00:37 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/3b07a12e1aed39e05a3f190e093911671a254af0
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b