Issue 10151043: code review 10151043: go.crypto: revert 7f5a59ff6b43.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10151043: code review 10151043: go.crypto: revert 7f5a59ff6b43. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by agl1

Modified:
10 years, 10 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

go.crypto: revert 7f5a59ff6b43. This change reverts https://codereview.appspot.com/10113043/ because some folks are stuck on 1.0 till 1.1.1 comes out.

Patch Set 1 #

Patch Set 2 : diff -r 7f5a59ff6b43 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 7f5a59ff6b43 https://code.google.com/p/go.crypto #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
M	openpgp/keys.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	openpgp/packet/packet.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	openpgp/packet/public_key.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ssh/channel.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ssh/client_auth.go	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ssh/server.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ssh/server_terminal.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ssh/session_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ssh/transport.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

10 years, 10 months ago (2013-06-10 14:56:59 UTC) #1

agl1

10 years, 10 months ago (2013-06-10 14:57:05 UTC) #2

*** Submitted as
https://code.google.com/p/go/source/detail?r=64ed55c0ea32&repo=crypto ***

go.crypto: revert 7f5a59ff6b43.

This change reverts https://codereview.appspot.com/10113043/ because
some folks are stuck on 1.0 till 1.1.1 comes out.

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/10151043

Expand All Messages | Collapse All Messages