code review 10151043: go.crypto: revert 7f5a59ff6b43.

openpgp/packet/packet.go

 // Copyright 2011 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // Package packet implements parsing and serialization of OpenPGP packets, as
 // specified in RFC 4880.
 package packet
 
 import (
         "code.google.com/p/go.crypto/cast5"
@@ skipping 254 matching lines @@
                 m, err = r.Read(buf[:])
                 n += int64(m)
                 if err == io.EOF {
                         err = nil
                         return
                 }
                 if err != nil {
                         return
                 }
         }
+
+        panic("unreachable")
 }
 
 // packetType represents the numeric ids of the different OpenPGP packet types. See
 // http://www.iana.org/assignments/pgp-parameters/pgp-parameters.xhtml#pgp-parameters-2
 type packetType uint8
 
 const (
         packetTypeEncryptedKey              packetType = 1
         packetTypeSignature                 packetType = 2
         packetTypeSymmetricKeyEncrypted     packetType = 3
@@ skipping 194 matching lines @@
         if err == nil {
                 _, err = w.Write(mpiBytes)
         }
         return
 }
 
 // writeBig serializes a *big.Int to w.
 func writeBig(w io.Writer, i *big.Int) error {
         return writeMPI(w, uint16(i.BitLen()), i.Bytes())
 }