Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1476)

Issue 10045046: Apply yuidoc's internal linting to our docs.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by benji
Modified:
7 years, 3 months ago
Reviewers:
mp+167627, jeff.pihach, rharding
Visibility:
Public.

Description

Apply yuidoc's internal linting to our docs. - turn on yuidoc's linting - rename the 'yuidoc-lint' target to 'lint-yuidoc' to follow recent pattern - fix all the lint errors it found https://code.launchpad.net/~benji/juju-gui/lint-yuidoc/+merge/167627 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 9

Patch Set 2 : Apply yuidoc's internal linting to our docs. #

Total comments: 2

Patch Set 3 : Apply yuidoc's internal linting to our docs. #

Patch Set 4 : Apply yuidoc's internal linting to our docs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -45 lines) Patch
M Makefile View 1 2 3 4 chunks +8 lines, -6 lines 0 comments Download
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +1 line, -1 line 0 comments Download
M app/models/browser.js View 1 chunk +1 line, -1 line 0 comments Download
M app/models/charm.js View 2 chunks +4 lines, -6 lines 0 comments Download
M app/models/handlers.js View 1 chunk +1 line, -1 line 0 comments Download
M app/models/models.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M app/store/env/fakebackend.js View 4 chunks +8 lines, -10 lines 0 comments Download
M app/subapps/browser/browser.js View 1 2 3 6 chunks +8 lines, -1 line 0 comments Download
M app/views/topology/utils.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/views/utils.js View 1 2 6 chunks +15 lines, -18 lines 0 comments Download
M app/widgets/charm-search.js View 1 chunk +1 line, -1 line 0 comments Download
M app/widgets/charm-token.js View 1 chunk +1 line, -0 lines 0 comments Download
M undocumented View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7
benji
Please take a look.
7 years, 3 months ago (2013-06-05 19:39:18 UTC) #1
jeff.pihach
Thanks for the cleanup LGTM with some trivial comments below. https://codereview.appspot.com/10045046/diff/1/app/subapps/browser/browser.js File app/subapps/browser/browser.js (right): https://codereview.appspot.com/10045046/diff/1/app/subapps/browser/browser.js#newcode819 ...
7 years, 3 months ago (2013-06-05 19:53:21 UTC) #2
benji
Thanks for the review. I had a question for you on the read-only attribute. https://codereview.appspot.com/10045046/diff/1/app/subapps/browser/browser.js ...
7 years, 3 months ago (2013-06-05 20:01:04 UTC) #3
benji
Please take a look. https://codereview.appspot.com/10045046/diff/1/app/subapps/browser/browser.js File app/subapps/browser/browser.js (right): https://codereview.appspot.com/10045046/diff/1/app/subapps/browser/browser.js#newcode819 app/subapps/browser/browser.js:819: @readOnly On 2013/06/05 20:01:04, benji ...
7 years, 3 months ago (2013-06-05 20:17:22 UTC) #4
rharding
LGTM I'm not a fan but oh well. While you're editing the *, might as ...
7 years, 3 months ago (2013-06-06 12:01:46 UTC) #5
benji
rharding@mitechie.com wrote: > LGTM I'm not a fan but oh well. You not being a ...
7 years, 3 months ago (2013-06-06 12:37:43 UTC) #6
benji
7 years, 3 months ago (2013-06-06 14:05:57 UTC) #7
*** Submitted:

Apply yuidoc's internal linting to our docs.

- turn on yuidoc's linting
- rename the 'yuidoc-lint' target to 'lint-yuidoc' to follow recent pattern
- fix all the lint errors it found

R=jeff.pihach, rharding
CC=
https://codereview.appspot.com/10045046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b