Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(124)

Delta Between Two Patch Sets: Makefile

Issue 10045046: Apply yuidoc's internal linting to our docs.
Left Patch Set: Created 10 years, 9 months ago
Right Patch Set: Apply yuidoc's internal linting to our docs. Created 10 years, 9 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | [revision details] » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # Makefile debugging hack: uncomment the two lines below and make will tell you 1 # Makefile debugging hack: uncomment the two lines below and make will tell you
2 # more about what is happening. The output generated is of the form 2 # more about what is happening. The output generated is of the form
3 # "FILE:LINE [TARGET (DEPENDENCIES) (NEWER)]" where DEPENDENCIES are all the 3 # "FILE:LINE [TARGET (DEPENDENCIES) (NEWER)]" where DEPENDENCIES are all the
4 # things TARGET depends on and NEWER are all the files that are newer than 4 # things TARGET depends on and NEWER are all the files that are newer than
5 # TARGET. DEPENDENCIES will be colored green and NEWER will be blue. 5 # TARGET. DEPENDENCIES will be colored green and NEWER will be blue.
6 # 6 #
7 #OLD_SHELL := $(SHELL) 7 #OLD_SHELL := $(SHELL)
8 #SHELL = $(warning [$@ ($^) ($?) ])$(OLD_SHELL) 8 #SHELL = $(warning [$@ ($^) ($?) ])$(OLD_SHELL)
9 9
10 # Build a target for JavaScript files. The find command excludes directories 10 # Build a target for JavaScript files. The find command excludes directories
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 node_modules/.bin/yuidoc --lint -x assets app 266 node_modules/.bin/yuidoc --lint -x assets app
267 bin/lint-yuidoc 267 bin/lint-yuidoc
268 268
269 recess: node_modules/recess 269 recess: node_modules/recess
270 @# We need to grep for "Perfect" because recess does not set a 270 @# We need to grep for "Perfect" because recess does not set a
271 @# non-zero exit code if it rejects a file. If this fails, run the 271 @# non-zero exit code if it rejects a file. If this fails, run the
272 @# recess command below without the grep to get recess' report. 272 @# recess command below without the grep to get recess' report.
273 node_modules/recess/bin/recess lib/views/stylesheet.less \ 273 node_modules/recess/bin/recess lib/views/stylesheet.less \
274 --config recess.json | grep -q Perfect 274 --config recess.json | grep -q Perfect
275 275
276 lint: test-prep jshint gjslint recess lint-yuidoc test-filtering 276 lint: test-prep jshint gjslint recess lint-license-headers test-filtering \
277 » » lint-yuidoc
278
279 lint-license-headers:
280 » @# Take the list of JS files in one long line and break them into
281 » @# multiple lines (this assumes there are no spaces in the paths).
282 » @# Remove non-JS files, remove third-party files, and remove files in
283 » @# the root of the project. Finally, search for copyright notices in
284 » @# the files and report files that do not have one.
285 » echo $(JSFILES) | sed 's/ /\n/g' \
286 » | grep '\.js$$' | grep -v /assets/ | grep / \
287 » | xargs -I {} sh -c "grep -L '^Copyright (C) 2[^ ]* Canonical Ltd.' {}" \
288 » || (echo "The above files are missing copyright headers."; false)
277 289
278 virtualenv/bin/python: 290 virtualenv/bin/python:
279 virtualenv virtualenv 291 virtualenv virtualenv
280 292
281 virtualenv/bin/gjslint virtualenv/bin/fixjsstyle: virtualenv/bin/python 293 virtualenv/bin/gjslint virtualenv/bin/fixjsstyle: virtualenv/bin/python
282 virtualenv/bin/easy_install archives/closure_linter-latest.tar.gz 294 virtualenv/bin/easy_install archives/closure_linter-latest.tar.gz
283 295
284 beautify: virtualenv/bin/fixjsstyle 296 beautify: virtualenv/bin/fixjsstyle
285 virtualenv/bin/fixjsstyle --strict --nojsdoc --jslint_error=all $(JSFILE S) 297 virtualenv/bin/fixjsstyle --strict --nojsdoc --jslint_error=all $(JSFILE S)
286 298
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 599
588 # targets are alphabetically sorted, they like it that way :-) 600 # targets are alphabetically sorted, they like it that way :-)
589 .PHONY: beautify build build-files build-devel clean clean-all clean-deps \ 601 .PHONY: beautify build build-files build-devel clean clean-all clean-deps \
590 clean-docs code-doc debug devel docs dist gjslint help \ 602 clean-docs code-doc debug devel docs dist gjslint help \
591 install-npm-packages jshint lint lint-yuidoc main-doc npm-cache \ 603 install-npm-packages jshint lint lint-yuidoc main-doc npm-cache \
592 npm-cache-file prep prod recess server spritegen test test-debug \ 604 npm-cache-file prep prod recess server spritegen test test-debug \
593 test-misc test-prep test-prod undocumented view-code-doc view-docs \ 605 test-misc test-prep test-prod undocumented view-code-doc view-docs \
594 view-main-doc 606 view-main-doc
595 607
596 .DEFAULT_GOAL := all 608 .DEFAULT_GOAL := all
LEFTRIGHT
« no previous file | [revision details] » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b