code review 9997043: time: provide timezone abbreviations on windows

time: provide timezone abbreviations on windows

Use http://unicode.org/cldr/data/common/supplemental/windowsZones.xml
to generate the map.

Fixes issue 4838.

[brainman, 2013-06-04 07:48:39]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2013-06-04 11:44:47]

LGTM

https://codereview.appspot.com/9997043/diff/5001/lib/time/genzabbrs.go
File lib/time/genzabbrs.go (right):

https://codereview.appspot.com/9997043/diff/5001/lib/time/genzabbrs.go#newcode8
lib/time/genzabbrs.go:8: // go run genzabbrs.go | gofmt >
$GOROOT/src/pkg/time/zoneinfo_abbrs_windows.go
This program belongs in src/pkg/time, not here.
Put // +build ignore at the top (after the copyright) to make that work.

Please create a Makefile containing:

windows:
    go run genzabbrs.go | gofmt >zoneinfo_abbrs_window.go

so that people can just run 'make windows'.

https://codereview.appspot.com/9997043/diff/5001/lib/time/genzabbrs.go#newcod...
lib/time/genzabbrs.go:105: const prog = `
Please move this to the bottom of the file (after func main). It's nice to know
that once you see the template program you've reached the end of the real
program.

https://codereview.appspot.com/9997043/diff/5001/lib/time/genzabbrs.go#newcod...
lib/time/genzabbrs.go:121: {{range .Zs}}	"{{.WinName}}": abbr{"{{.StTime}}",
"{{.DSTime}}"}, // {{.UnixName}}
s/abbr//

[brainman, 2013-06-06 06:30:35]

*** Submitted as https://code.google.com/p/go/source/detail?r=60e04bb0d8b9 ***

time: provide timezone abbreviations on windows

Use http://unicode.org/cldr/data/common/supplemental/windowsZones.xml
to generate the map.

Fixes issue 4838.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/9997043

https://codereview.appspot.com/9997043/diff/5001/lib/time/genzabbrs.go
File lib/time/genzabbrs.go (right):

https://codereview.appspot.com/9997043/diff/5001/lib/time/genzabbrs.go#newcode8
lib/time/genzabbrs.go:8: // go run genzabbrs.go | gofmt >
$GOROOT/src/pkg/time/zoneinfo_abbrs_windows.go
On 2013/06/04 11:44:47, rsc wrote:
> ...
> Please create a Makefile containing:
> 
> windows:
>     go run genzabbrs.go | gofmt >zoneinfo_abbrs_window.go

I had to split this into 2 step process (build genzabbrs executable, then run
it), because it overwrites time package files if it built in one step and fails
to build. Just like it is done in pkg/unicode.

https://codereview.appspot.com/9997043/diff/5001/lib/time/genzabbrs.go#newcod...
lib/time/genzabbrs.go:105: const prog = `
On 2013/06/04 11:44:47, rsc wrote:
> Please move this to the bottom of the file (after func main). It's nice to
know
> that once you see the template program you've reached the end of the real
> program.

Done.

https://codereview.appspot.com/9997043/diff/5001/lib/time/genzabbrs.go#newcod...
lib/time/genzabbrs.go:121: {{range .Zs}}	"{{.WinName}}": abbr{"{{.StTime}}",
"{{.DSTime}}"}, // {{.UnixName}}
On 2013/06/04 11:44:47, rsc wrote:
> s/abbr//

Done.