Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(234)

Issue 99960043: Added proper errortype in testservices.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by hduran
Modified:
6 years, 1 month ago
Reviewers:
axw, mp+217818
Visibility:
Public.

Description

Added proper errortype in testservices. Added an error type for testservers that contains a message and an error code. Switched novaservice to use new error type. https://code.launchpad.net/~hduran-8/goose/testservice_errors/+merge/217818 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 7

Patch Set 2 : Added proper errortype in testservices. #

Total comments: 1

Patch Set 3 : Added proper errortype in testservices. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -58 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A testservices/errors.go View 1 2 1 chunk +137 lines, -0 lines 0 comments Download
A testservices/errors_test.go View 1 1 chunk +29 lines, -0 lines 0 comments Download
M testservices/novaservice/service.go View 21 chunks +21 lines, -21 lines 0 comments Download
M testservices/novaservice/service_test.go View 29 chunks +33 lines, -33 lines 0 comments Download
M testservices/service.go View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5
hduran
Please take a look.
6 years, 1 month ago (2014-04-30 19:41:19 UTC) #1
axw
https://codereview.appspot.com/99960043/diff/1/testservices/errors.go File testservices/errors.go (right): https://codereview.appspot.com/99960043/diff/1/testservices/errors.go#newcode5 testservices/errors.go:5: var nameReference = map[int]string{ Where do these values come ...
6 years, 1 month ago (2014-04-30 21:40:00 UTC) #2
hduran
Please take a look.
6 years, 1 month ago (2014-04-30 22:28:15 UTC) #3
axw
LGTM with an added comment https://codereview.appspot.com/99960043/diff/20001/testservices/errors.go File testservices/errors.go (right): https://codereview.appspot.com/99960043/diff/20001/testservices/errors.go#newcode5 testservices/errors.go:5: var nameReference = map[int]string{ ...
6 years, 1 month ago (2014-04-30 22:33:36 UTC) #4
hduran
6 years, 1 month ago (2014-04-30 23:17:32 UTC) #5
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b