code review 99910043: time: MeST is a time zone name

time: MeST is a time zone name

Not only ChST but also MeST (America/Metlakatla) is a zone
name containing a lower case letter.

[ruiu, 2014-04-30 02:22:13]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rh, 2014-04-30 12:22:41]

On 2014/04/30 02:22:13, ruiu wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go

LGTM

How did you find this, out of curiosity?  It took me some research to find
mentions of MeST.

[bradfitz, 2014-04-30 14:11:12]

R=r



On Tue, Apr 29, 2014 at 7:22 PM, ruiu via golang-codereviews <
golang-codereviews@googlegroups.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> time: MeST is a time zone name
>
> Not only ChST but also MeST (America/Metlakatla) is a zone
> name containing a lower case letter.
>
> Please review this at https://codereview.appspot.com/99910043/
>
> Affected files (+3, -2 lines):
>   M src/pkg/time/format.go
>   M src/pkg/time/format_test.go
>
>
> Index: src/pkg/time/format.go
> ===================================================================
> --- a/src/pkg/time/format.go
> +++ b/src/pkg/time/format.go
> @@ -1037,8 +1037,8 @@
>         if len(value) < 3 {
>                 return 0, false
>         }
> -       // Special case 1: This is the only zone with a lower-case letter.
> -       if len(value) >= 4 && value[:4] == "ChST" {
> +       // Special case 1: ChST and MeST are the only zones with a
> lower-case letter.
> +       if len(value) >= 4 && (value[:4] == "ChST" || value[:4] == "MeST")
> {
>                 return 4, true
>         }
>         // Special case 2: GMT may have an hour offset; treat it specially.
> Index: src/pkg/time/format_test.go
> ===================================================================
> --- a/src/pkg/time/format_test.go
> +++ b/src/pkg/time/format_test.go
> @@ -331,6 +331,7 @@
>         {"GMT-5 hi there", 5, true},
>         {"GMT-51 hi there", 3, true},
>         {"ChST hi there", 4, true},
> +       {"MeST hi there", 4, true},
>         {"MSDx", 3, true},
>         {"MSDY", 0, false}, // four letters must end in T.
>         {"ESAST hi", 5, true},
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[r, 2014-04-30 15:25:44]

LGTM
sigh

[r, 2014-04-30 15:30:38]

*** Submitted as https://code.google.com/p/go/source/detail?r=d5eddae99d9c ***

time: MeST is a time zone name

Not only ChST but also MeST (America/Metlakatla) is a zone
name containing a lower case letter.

LGTM=robert.hencke, r
R=golang-codereviews, robert.hencke, bradfitz, r
CC=golang-codereviews
https://codereview.appspot.com/99910043

Committer: Rob Pike <r@golang.org>

[ruiu, 2014-04-30 15:53:48]

On 2014/04/30 12:22:41, rh wrote:
> On 2014/04/30 02:22:13, ruiu wrote:
> > Hello mailto:golang-codereviews@googlegroups.com,
> > 
> > I'd like you to review this change to
> > https://code.google.com/p/go
> 
> LGTM
> 
> How did you find this, out of curiosity?  It took me some research to find
> mentions of MeST.

I read the comment and wondered if that's true, so I grepped the IANA database.