Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(972)

Issue 9984046: state/open.go: Remove RetryDelay

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by jameinel
Modified:
10 years, 10 months ago
Reviewers:
gz, mp+167264, dimitern
Visibility:
Public.

Description

state/open.go: Remove RetryDelay The latest version of mgo always delays 500ms between every retry. This would mean that we delay both that 500ms and the extra time that we had internally. Instead, this removes our internal delay, and the test that asserted we did not delay when it was a TLS failure rather than a connection failure. mgo does not appear to expose any way to control the retry delay, but it does seem close enough for what we wanted to do that we can live with it. https://code.launchpad.net/~jameinel/juju-core/timeout-bug-1183320/+merge/167264 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/open.go: Remove RetryDelay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -53 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/api_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M state/open.go View 2 chunks +2 lines, -8 lines 0 comments Download
M state/settings_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M state/state_test.go View 4 chunks +5 lines, -41 lines 0 comments Download

Messages

Total messages: 4
jameinel
Please take a look.
10 years, 10 months ago (2013-06-04 13:02:08 UTC) #1
gz
LGTM
10 years, 10 months ago (2013-06-05 11:48:29 UTC) #2
dimitern
LGTM
10 years, 10 months ago (2013-06-05 12:00:48 UTC) #3
jameinel
10 years, 10 months ago (2013-06-05 12:03:54 UTC) #4
*** Submitted:

state/open.go: Remove RetryDelay

The latest version of mgo always delays 500ms between every retry. This would
mean that we delay both that 500ms and the extra time that we had internally.
Instead, this removes our internal delay, and the test that asserted we did not
delay when it was a TLS failure rather than a connection failure.

mgo does not appear to expose any way to control the retry delay, but
it does seem close enough for what we wanted to do that we can live
with it.

R=gz, dimitern
CC=
https://codereview.appspot.com/9984046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b