Issue 99800043: code review 99800043: leveldb: when closing a DB, wait for any in-flight comp...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 99800043: code review 99800043: leveldb: when closing a DB, wait for any in-flight comp... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by nigeltao

Modified:
10 years, 7 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-codereviews

Visibility:
Public.

Description

leveldb: when closing a DB, wait for any in-flight compaction to complete before cleaning up the table cache. Fixes issue 14.

Patch Set 1 #

Patch Set 2 : diff -r 48507a759c8d https://code.google.com/p/leveldb-go #

Patch Set 3 : diff -r 48507a759c8d https://code.google.com/p/leveldb-go #

Patch Set 4 : diff -r 48507a759c8d https://code.google.com/p/leveldb-go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -54 lines)			Patch
M	leveldb/compaction.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	leveldb/leveldb.go	View	1	2 chunks	+9 lines, -4 lines	0 comments	Download
M	leveldb/leveldb_test.go	View	1	1 chunk	+61 lines, -48 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/leveldb-go

10 years, 7 months ago (2014-04-26 22:03:01 UTC) #1

nigeltao

10 years, 7 months ago (2014-04-26 22:24:36 UTC) #3

*** Submitted as
https://code.google.com/p/leveldb-go/source/detail?r=ddb33fbf1c47 ***

leveldb: when closing a DB, wait for any in-flight compaction to
complete before cleaning up the table cache.

Fixes issue 14.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/99800043

Expand All Messages | Collapse All Messages