Issue 9965045: code review 9965045: cmd/cgo, cmd/go, go/build: sort flag lists

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9965045: code review 9965045: cmd/cgo, cmd/go, go/build: sort flag lists (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rsc

Modified:
12 years, 1 month ago

Reviewers:
iant

CC:
golang-dev, iant, Hierro

Visibility:
Public.

Description

cmd/cgo, cmd/go, go/build: sort flag lists CFLAGS comes before CPPFLAGS. Also fix one typo CPPCFLAGS. Cleanup for CL 8248043.

Patch Set 1 #

Patch Set 2 : diff -r 6dad366e9f94 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 24deeb374803 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 24deeb374803 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 24deeb374803 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 24deeb374803 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	src/cmd/cgo/doc.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/go/doc.go	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/go/list.go	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/go/pkg.go	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/go/build/build.go	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-06-03 21:03:37 UTC) #1

iant

LGTM The way they were makes sense too as CPPFLAGS must appear on the command ...

12 years, 1 month ago (2013-06-03 21:09:18 UTC) #2

Hierro

On 2013/06/03 21:09:18, iant wrote: > LGTM > > The way they were makes sense ...

12 years, 1 month ago (2013-06-03 23:02:54 UTC) #3

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=2449e85a1150 *** cmd/cgo, cmd/go, go/build: sort flag lists CFLAGS comes before CPPFLAGS. ...

12 years, 1 month ago (2013-06-05 11:14:11 UTC) #4

rsc

12 years, 1 month ago (2013-06-05 14:34:59 UTC) #5

In general if a list is mostly sorted, it should be completely sorted.
Otherwise it both looks like a mistake and makes things hard to find.

The exception in that list, of course, is the Go files, which come first
because, well, this is Go.

You're right that the swig entries should be sorted into place. I've done
that too.

Russ

Expand All Messages | Collapse All Messages