Issue 9964044: Fixes black bar on fullscreen charmdetails

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9964044: Fixes black bar on fullscreen charmdetails

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by j.c.sackett

Modified:
10 years, 10 months ago

Reviewers:
rharding, jeff.pihach, mp+167595

Visibility:
Public.

Description

Fixes black bar on fullscreen charmdetails The error was happening b/c charmdetails was reloading multiple times, which broke its render state. The multiple reloads were from _stripViewMode returning "/series/charmname-revno" or "series/charmname-revno", depending on inputs. -_stripViewMode now always removes the preceding slash on the charmID -_stripViewMode is now tested for all paths it can receive https://code.launchpad.net/~jcsackett/juju-gui/black-bar-of-horrible/+merge/167595 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes black bar on fullscreen charmdetails #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -2 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/browser.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/subapps/browser/views/charm.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_browser_app.js	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

j.c.sackett

10 years, 10 months ago (2013-06-05 17:36:09 UTC) #4

*** Submitted:

Fixes black bar on fullscreen charmdetails

The error was happening b/c charmdetails was reloading multiple times, which
broke its render state. The multiple reloads were from _stripViewMode
returning "/series/charmname-revno" or "series/charmname-revno", depending on
inputs.
-_stripViewMode now always removes the preceding slash on the charmID
-_stripViewMode is now tested for all paths it can receive

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/9964044

Expand All Messages | Collapse All Messages