Issue 99640043: Refactor to callback services API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 99640043: Refactor to callback services API

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by johnsca

Modified:
9 years, 11 months ago

Reviewers:
mp+221444, benjamin.saller

Visibility:
Public.

Description

Refactor to callback services API https://code.launchpad.net/~johnsca/charms/trusty/cf-loggregator/services-callback-fu/+merge/221444 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Refactor to callback services API #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+455 lines, -337 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	hooks/charmhelpers/contrib/cloudfoundry/contexts.py	View	1 chunk	+41 lines, -32 lines	0 comments	Download
M	hooks/charmhelpers/core/host.py	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	hooks/charmhelpers/core/services.py	View	1 chunk	+316 lines, -79 lines	0 comments	Download
M	hooks/charmhelpers/core/templating.py	View	2 chunks	+44 lines, -146 lines	0 comments	Download
M	hooks/config.py	View	2 chunks	+20 lines, -0 lines	0 comments	Download
D	hooks/hooks.py	View	5 chunks	+27 lines, -80 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM, though for some of these the rietveld isn't showing the hooks in a reasonable ...

9 years, 11 months ago (2014-05-29 18:48:39 UTC) #2

johnsca

9 years, 11 months ago (2014-05-29 20:25:00 UTC) #3

*** Submitted:

Refactor to callback services API

R=benjamin.saller
CC=
https://codereview.appspot.com/99640043

Expand All Messages | Collapse All Messages