code review 9961046: go.net/ipv6: add Close method to PacketConn

go.net/ipv6: add Close method to PacketConn

[mikio, 2013-06-05 10:04:31]

Hello dave@cheney.net (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net

[dave_cheney.net, 2013-06-05 10:39:50]

LGTM. During the conversation on
https://codereview.appspot.com/10043043/ it was agreed that we
_should_ have Close methods on PacketConn to provide a mechanism to
avoid leaking the underlying net type and thus the file descriptor.

On Wed, Jun 5, 2013 at 8:04 PM,  <mikioh.mikioh@gmail.com> wrote:
> Reviewers: dfc,
>
> Message:
> Hello dave@cheney.net (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.net
>
>
> Description:
> go.net/ipv6: add Close method to PacketConn
>
> Please review this at https://codereview.appspot.com/9961046/
>
> Affected files:
>   M ipv6/endpoint.go
>
>
> Index: ipv6/endpoint.go
> ===================================================================
> --- a/ipv6/endpoint.go
> +++ b/ipv6/endpoint.go
> @@ -72,6 +72,14 @@
>         return setControlMessage(fd, &c.payloadHandler.rawOpt, cf, on)
>  }
>
> +// Close closes the endpoint.
> +func (c *PacketConn) Close() error {
> +       if !c.payloadHandler.ok() {
> +               return syscall.EINVAL
> +       }
> +       return c.payloadHandler.PacketConn.Close()
> +}
> +
>  // NewPacketConn returns a new PacketConn using c as its underlying
>  // transport.
>  func NewPacketConn(c net.PacketConn) *PacketConn {
>
>

[mikio, 2013-06-05 11:08:17]

*** Submitted as
https://code.google.com/p/go/source/detail?r=481670f799b5&repo=net ***

go.net/ipv6: add Close method to PacketConn

R=dave
CC=golang-dev
https://codereview.appspot.com/9961046

[capnm, 2013-06-05 20:28:00]

On 2013/06/05 11:08:17, mikio wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=481670f799b5&repo=net ***
> 
> go.net/ipv6: add Close method to PacketConn
> 
> R=dave
> CC=golang-dev
> https://codereview.appspot.com/9961046


I suspect one of the recent ipv6 changes brought this on arm:

uname -a
Linux rpi 3.6.11+ #456 PREEMPT Mon May 20 17:42:15 BST 2013 armv6l GNU/Linux

ok  	code.google.com/p/go.net/ipv4	0.143s
--- FAIL: TestUDPSinglePacketConnWithMultipleGroupListeners (0.01 seconds)
	multicastlistener_test.go:31: net.ListenPacket failed: listen udp6 [::]:0:
address family not supported by protocol
--- FAIL: TestUDPMultipleConnWithMultipleGroupListeners (0.01 seconds)
	multicastlistener_test.go:68: net.ListenPacket failed: listen udp6
[ff02::]:1024: address family not supported by protocol
--- FAIL: TestConnInitiatorPathMTU (0.01 seconds)
	sockopt_test.go:32: net.Listen failed: listen tcp6 [::1]:0: address family not
supported by protocol
--- FAIL: TestConnResponderPathMTU (0.01 seconds)
	sockopt_test.go:62: net.Listen failed: listen tcp6 [::1]:0: address family not
supported by protocol
--- FAIL: TestPacketConnReadWriteUnicastUDP (0.01 seconds)
	unicast_test.go:94: net.ListenPacket failed: listen udp6 [::1]:0: address
family not supported by protocol
--- FAIL: TestConnUnicastSocketOptions (0.01 seconds)
	unicastsockopt_test.go:23: net.Listen failed: listen tcp6 [::1]:0: address
family not supported by protocol
--- FAIL: TestPacketConnUnicastSocketOptions (0.01 seconds)
	unicastsockopt_test.go:60: net.ListenPacket("udp6", "[::1]:0") failed: listen
udp6 [::1]:0: address family not supported by protocol
FAIL
FAIL	code.google.com/p/go.net/ipv6	0.178s

[mikio, 2013-06-05 21:38:37]

On Thu, Jun 6, 2013 at 5:28 AM,  <capnm9@gmail.com> wrote:

> I suspect one of the recent ipv6 changes brought this on arm:
>
> uname -a
> Linux rpi 3.6.11+ #456 PREEMPT Mon May 20 17:42:15 BST 2013 armv6l
> GNU/Linux

Will add IPv6 capability check to test cases, thanks.