Issue 99570043: code review 99570043: acme: increase timer resolution to 10ms

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 99570043: code review 99570043: acme: increase timer resolution to 10ms (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by rsc

Modified:
9 years, 10 months ago

Reviewers:
aram, r

CC:
r, aram

Visibility:
Public.

Description

acme: increase timer resolution to 10ms We ran for a long time with 10ms kernel resolution, so 10ms user space resolution here should be fine. Some systems actually provide 1ms sleeps, which makes this polling use a bit more cpu than we'd like. Since the timers are for user-visible things, 10ms should still be far from noticeable. Reduces acme's cpu usage on Macs when plumber is missing (and plumbproc is sleeping waiting for it to appear).

Patch Set 1 #

Patch Set 2 : diff -r ed3ca4576def https://code.google.com/p/plan9port #

Patch Set 3 : diff -r ed3ca4576def https://code.google.com/p/plan9port #

Patch Set 4 : diff -r ed3ca4576def https://code.google.com/p/plan9port #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/acme/time.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r, I'd like you to review this change to https://code.google.com/p/plan9port

9 years, 11 months ago (2014-05-28 18:30:43 UTC) #1

rsc

9 years, 10 months ago (2014-06-03 04:09:24 UTC) #4

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=f61195d7dce0 ***

acme: increase timer resolution to 10ms

We ran for a long time with 10ms kernel resolution,
so 10ms user space resolution here should be fine.
Some systems actually provide 1ms sleeps, which
makes this polling use a bit more cpu than we'd like.
Since the timers are for user-visible things, 10ms should
still be far from noticeable.

Reduces acme's cpu usage on Macs when plumber is missing
(and plumbproc is sleeping waiting for it to appear).

LGTM=aram, r
R=r, aram
https://codereview.appspot.com/99570043

Expand All Messages | Collapse All Messages