Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(213)

Issue 9955043: code review 9955043: testing: fix a goroutine leak in threadRing stresstest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by robryk
Modified:
8 years, 7 months ago
Reviewers:
r, dfc, dvyukov
CC:
golang-dev, dvyukov
Visibility:
Public.

Description

testing: fix a goroutine leak in threadRing stresstest Fixes issue 5527.

Patch Set 1 #

Patch Set 2 : diff -r c42a7c218440 https://code.google.com/p/go/ #

Patch Set 3 : diff -r c42a7c218440 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M test/stress/runstress.go View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7
robryk
After running GOMAXPROCS=2 ./stress -exec=false -maps=false -net=false -parsego=false for half an hour, the virtual memory ...
8 years, 7 months ago (2013-06-03 01:51:20 UTC) #1
robryk
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
8 years, 7 months ago (2013-06-03 01:51:45 UTC) #2
dvyukov
LGTM
8 years, 7 months ago (2013-06-03 04:48:18 UTC) #3
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=bc2993c5834f *** test/stress: fix a goroutine leak in threadRing stresstest Fixes issue ...
8 years, 7 months ago (2013-06-03 14:07:42 UTC) #4
dfc
Any chance of getting this merged to the 1.1 branch? On 04/06/2013, at 0:07, bradfitz@golang.org ...
8 years, 7 months ago (2013-06-05 03:35:58 UTC) #5
r
A leak in a test doesn't seem like a critical fix to me. We'd like ...
8 years, 7 months ago (2013-06-05 03:40:14 UTC) #6
dfc
8 years, 7 months ago (2013-06-05 03:44:09 UTC) #7
Not a problem, I'll patch this in manually when testing the branch. 



On 05/06/2013, at 13:39, Rob Pike <r@golang.org> wrote:

> A leak in a test doesn't seem like a critical fix to me. We'd like to
> keep the changes to the branch to a minimum.
> 
> -rob
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b