Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1322)

Issue 9953045: Adds a websocket recording and download feature.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by benji
Modified:
10 years, 10 months ago
Reviewers:
bac, teknico, mp+167034
Visibility:
Public.

Description

Adds a websocket recording and download feature. When the websocket_capture feature flag is enabled (e.g., /:flags:/websocket_capture/) the websocket traffic will be recorded. When the user presses Control-Shift-d, the log will be downloaded to their local machine. https://code.launchpad.net/~benji/juju-gui/websocket-logging/+merge/167034 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 14

Patch Set 2 : Adds a websocket recording and download feature. #

Patch Set 3 : Adds a websocket recording and download feature. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -11 lines) Patch
M Makefile View 1 2 chunks +2 lines, -0 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 4 chunks +13 lines, -1 line 0 comments Download
M app/assets/javascripts/reconnecting-websocket.js View 9 chunks +10 lines, -8 lines 0 comments Download
M app/modules-debug.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
A app/websocket-logging.js View 1 1 chunk +123 lines, -0 lines 0 comments Download
M lib/websocketreplay.py View 1 chunk +8 lines, -2 lines 0 comments Download
M test/index.html View 1 chunk +1 line, -0 lines 0 comments Download
A test/test_websocket_logging.js View 1 1 chunk +109 lines, -0 lines 0 comments Download
M test/test_websocketreplay.py View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 5
benji
Please take a look.
10 years, 10 months ago (2013-06-03 13:09:53 UTC) #1
bac
LGTM with minors. https://codereview.appspot.com/9953045/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/9953045/diff/1/Makefile#newcode320 Makefile:320: build-debug/juju-ui/websocketLogging.js \ camelCaseFileNames? I-thought-we-liked-hyphens. https://codereview.appspot.com/9953045/diff/1/app/app.js File ...
10 years, 10 months ago (2013-06-03 14:14:04 UTC) #2
teknico
LGTM, nice, thanks.
10 years, 10 months ago (2013-06-03 17:13:54 UTC) #3
benji
Please take a look. https://codereview.appspot.com/9953045/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/9953045/diff/1/Makefile#newcode320 Makefile:320: build-debug/juju-ui/websocketLogging.js \ On 2013/06/03 14:14:04, ...
10 years, 10 months ago (2013-06-03 17:39:44 UTC) #4
benji
10 years, 10 months ago (2013-06-03 17:47:42 UTC) #5
*** Submitted:

Adds a websocket recording and download feature.

When the websocket_capture feature flag is enabled (e.g.,
/:flags:/websocket_capture/) the websocket traffic will be recorded.  When the
user presses Control-Shift-d, the log will be downloaded to their local
machine.

R=bac, teknico
CC=
https://codereview.appspot.com/9953045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b