Issue 9952043: code review 9952043: cmd/gc: do not corrupt init() with initializers of _ in...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9952043: code review 9952043: cmd/gc: do not corrupt init() with initializers of _ in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by remyoudompheng

Modified:
10 years, 11 months ago

Reviewers:
r, DMorsing

CC:
golang-dev, DMorsing, r, dsymonds

Visibility:
Public.

Description

cmd/gc: do not corrupt init() with initializers of _ in closures. Fixes issue 5607.

Patch Set 1 #

Patch Set 2 : diff -r 60c7f2814463 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 60c7f2814463 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 52cd05010748 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 52cd05010748 https://go.googlecode.com/hg/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -3 lines)			Patch
	M	src/cmd/gc/sinit.c	View	1 2 3	4 chunks	+7 lines, -3 lines	0 comments	Download
	A	test/fixedbugs/issue5607.go	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 11 months ago (2013-06-02 18:59:28 UTC) #1

remyoudompheng

2013/6/2 David Symonds <dsymonds@golang.org>: > Fix typo in comment. Done.

10 years, 11 months ago (2013-06-02 21:54:22 UTC) #5

remyoudompheng

10 years, 11 months ago (2013-06-02 21:54:38 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=c42a7c218440 ***

cmd/gc: do not corrupt init() with initializers of _ in closures.

Fixes issue 5607.

R=golang-dev, daniel.morsing, r, dsymonds
CC=golang-dev
https://codereview.appspot.com/9952043

Expand All Messages | Collapse All Messages