Issue 9947043: code review 9947043: cmd/fix: check type assertion in netipv6zone rule.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9947043: code review 9947043: cmd/fix: check type assertion in netipv6zone rule. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by remyoudompheng

Modified:
12 years ago

Reviewers:
r, mikio

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/fix: check type assertion in netipv6zone rule. Fixes issue 5461.

Patch Set 1 #

Patch Set 2 : code review 9947043: cmd/fix: check type assertion in netipv6zone rule. #

Patch Set 3 : diff -r 8c7d0793f4d5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8c7d0793f4d5 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8c7d0793f4d5 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/cmd/fix/netipv6zone.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/cmd/fix/netipv6zone_test.go	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-06-02 10:06:02 UTC) #1

remyoudompheng

*** Submitted as https://code.google.com/p/go/source/detail?r=b68a28adc900 *** cmd/fix: check type assertion in netipv6zone rule. Fixes issue 5461. ...

12 years ago (2013-06-02 13:39:55 UTC) #3

iant

12 years ago (2013-06-03 15:07:40 UTC) #5

On Sun, Jun 2, 2013 at 10:45 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
>
> Does this deserve to go in 1.1.1?

No.  There is a workaround.

Ian

Expand All Messages | Collapse All Messages