Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(758)

Issue 994044: code review 994044: 5l, 6l, 8l, runtime: make -s binaries work (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by rsc
Modified:
7 years, 6 months ago
Reviewers:
CC:
iant, r, golang-dev
Visibility:
Public.

Description

5l, 6l, 8l, runtime: make -s binaries work 5l, 6l, 8l: change ELF header so that strip doesn't destroy binary Fixes issue 261.

Patch Set 1 #

Patch Set 2 : code review 994044: 5l, 6l, 8l, runtime: make -s binaries work #

Patch Set 3 : code review 994044: 5l, 6l, 8l, runtime: make -s binaries work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -59 lines) Patch
M src/cmd/5l/asm.c View 9 chunks +50 lines, -13 lines 0 comments Download
M src/cmd/5l/l.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/cmd/5l/pass.c View 4 chunks +24 lines, -2 lines 0 comments Download
M src/cmd/5l/span.c View 2 chunks +7 lines, -0 lines 0 comments Download
M src/cmd/6l/asm.c View 7 chunks +37 lines, -10 lines 0 comments Download
M src/cmd/6l/l.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/cmd/6l/pass.c View 3 chunks +22 lines, -2 lines 0 comments Download
M src/cmd/6l/span.c View 3 chunks +8 lines, -0 lines 0 comments Download
M src/cmd/8l/asm.c View 7 chunks +32 lines, -11 lines 0 comments Download
M src/cmd/8l/l.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/cmd/8l/pass.c View 3 chunks +22 lines, -2 lines 0 comments Download
M src/cmd/8l/span.c View 3 chunks +8 lines, -0 lines 0 comments Download
M src/cmd/ld/elf.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ld/lib.h View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ld/lib.c View 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/symtab.c View 5 chunks +8 lines, -17 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello iant, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
7 years, 6 months ago (2010-04-28 00:39:13 UTC) #1
r
LGTM as far as i understand it, but iant should vet the ELF specifics.
7 years, 6 months ago (2010-04-28 00:42:31 UTC) #2
iant
LGTM The change to src/cmd/ld/lib.c seems unrelated.
7 years, 6 months ago (2010-04-28 05:32:27 UTC) #3
rsc
> The change to src/cmd/ld/lib.c seems unrelated. Indeed it is, except that I typed 5l ...
7 years, 6 months ago (2010-04-28 05:35:34 UTC) #4
rsc
7 years, 6 months ago (2010-04-28 05:40:32 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=063972cd31fa ***

5l, 6l, 8l, runtime: make -s binaries work
5l, 6l, 8l: change ELF header so that strip doesn't destroy binary

Fixes issue 261.

R=iant, r
CC=golang-dev
http://codereview.appspot.com/994044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4