src/cmd/8l/span.c - Issue 994044: code review 994044: 5l, 6l, 8l, runtime: make -s binaries work

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/8l/span.c

Issue 994044: code review 994044: 5l, 6l, 8l, runtime: make -s binaries work (Closed)

Patch Set: code review 994044: 5l, 6l, 8l, runtime: make -s binaries work Created 14 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/8l/span.c

===================================================================

--- a/src/cmd/8l/span.c

+++ b/src/cmd/8l/span.c

@@ -214,6 +214,7 @@

continue;

case SDATA:

+ case SELFDATA:

if(!s->reachable)

continue;

putsymb(s->name, 'D', s->value+INITDAT, s->version, s->gotype);

@@ -231,6 +232,10 @@

putsymb(s->name, 'B', s->value+INITDAT, s->version, s->gotype);

continue;

+ case SFIXED:

+ putsymb(s->name, 'B', s->value, s->version, s->gotype);

+ continue;

case SFILE:

putsymb(s->name, 'f', s->value, s->version, 0);

continue;

@@ -622,6 +627,9 @@

sysfatal("unreachable symbol in vaddr - %s", s->name);

v += INITDAT + datsize + s->value;

break;

+ case SFIXED:

+ v += s->value;

+ break;

default:

if(!s->reachable)

sysfatal("unreachable symbol in vaddr - %s", s->name);

« no previous file with comments | « src/cmd/8l/pass.c ('k') | src/cmd/ld/elf.c » ('j') | no next file with comments »