Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(541)

Issue 9940044: code review 9940044: cmd/fix: remove obsolete testdata. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by remyoudompheng
Modified:
12 years, 1 month ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

cmd/fix: remove obsolete testdata. The corresponding rules have been removed for Go 1.

Patch Set 1 #

Patch Set 2 : diff -r 8c7d0793f4d5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8c7d0793f4d5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b68a28adc900 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19227 lines) Patch
R src/cmd/fix/testdata/reflect.asn1.go.in View 1 1 chunk +0 lines, -814 lines 0 comments Download
R src/cmd/fix/testdata/reflect.asn1.go.out View 1 1 chunk +0 lines, -814 lines 0 comments Download
R src/cmd/fix/testdata/reflect.datafmt.go.in View 1 1 chunk +0 lines, -710 lines 0 comments Download
R src/cmd/fix/testdata/reflect.datafmt.go.out View 1 1 chunk +0 lines, -710 lines 0 comments Download
R src/cmd/fix/testdata/reflect.decode.go.in View 1 1 chunk +0 lines, -905 lines 0 comments Download
R src/cmd/fix/testdata/reflect.decode.go.out View 1 1 chunk +0 lines, -908 lines 0 comments Download
R src/cmd/fix/testdata/reflect.decoder.go.in View 1 1 chunk +0 lines, -196 lines 0 comments Download
R src/cmd/fix/testdata/reflect.decoder.go.out View 1 1 chunk +0 lines, -196 lines 0 comments Download
R src/cmd/fix/testdata/reflect.dnsmsg.go.in View 1 1 chunk +0 lines, -777 lines 0 comments Download
R src/cmd/fix/testdata/reflect.dnsmsg.go.out View 1 1 chunk +0 lines, -777 lines 0 comments Download
R src/cmd/fix/testdata/reflect.encode.go.in View 1 1 chunk +0 lines, -367 lines 0 comments Download
R src/cmd/fix/testdata/reflect.encode.go.out View 1 1 chunk +0 lines, -367 lines 0 comments Download
R src/cmd/fix/testdata/reflect.encoder.go.in View 1 1 chunk +0 lines, -240 lines 0 comments Download
R src/cmd/fix/testdata/reflect.encoder.go.out View 1 1 chunk +0 lines, -240 lines 0 comments Download
R src/cmd/fix/testdata/reflect.export.go.in View 1 1 chunk +0 lines, -400 lines 0 comments Download
R src/cmd/fix/testdata/reflect.export.go.out View 1 1 chunk +0 lines, -400 lines 0 comments Download
R src/cmd/fix/testdata/reflect.print.go.in View 1 1 chunk +0 lines, -944 lines 0 comments Download
R src/cmd/fix/testdata/reflect.print.go.out View 1 1 chunk +0 lines, -944 lines 0 comments Download
R src/cmd/fix/testdata/reflect.quick.go.in View 1 1 chunk +0 lines, -364 lines 0 comments Download
R src/cmd/fix/testdata/reflect.quick.go.out View 1 1 chunk +0 lines, -365 lines 0 comments Download
R src/cmd/fix/testdata/reflect.read.go.in View 1 1 chunk +0 lines, -620 lines 0 comments Download
R src/cmd/fix/testdata/reflect.read.go.out View 1 1 chunk +0 lines, -620 lines 0 comments Download
R src/cmd/fix/testdata/reflect.scan.go.in View 1 1 chunk +0 lines, -1082 lines 0 comments Download
R src/cmd/fix/testdata/reflect.scan.go.out View 1 1 chunk +0 lines, -1082 lines 0 comments Download
R src/cmd/fix/testdata/reflect.script.go.in View 1 1 chunk +0 lines, -359 lines 0 comments Download
R src/cmd/fix/testdata/reflect.script.go.out View 1 1 chunk +0 lines, -359 lines 0 comments Download
R src/cmd/fix/testdata/reflect.template.go.in View 1 1 chunk +0 lines, -1043 lines 0 comments Download
R src/cmd/fix/testdata/reflect.template.go.out View 1 1 chunk +0 lines, -1044 lines 0 comments Download
R src/cmd/fix/testdata/reflect.type.go.in View 1 1 chunk +0 lines, -790 lines 0 comments Download
R src/cmd/fix/testdata/reflect.type.go.out View 1 1 chunk +0 lines, -790 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2013-06-02 10:02:23 UTC) #1
r
LGTM
12 years, 1 month ago (2013-06-02 12:09:25 UTC) #2
remyoudompheng
12 years, 1 month ago (2013-06-02 13:40:41 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=f9e22f8aa00d ***

cmd/fix: remove obsolete testdata.

The corresponding rules have been removed for Go 1.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/9940044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b