Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
10 years, 7 months ago
(2014-05-16 18:33:44 UTC)
#2
Replacing golang-dev with golang-codereviews.
To the author of this CL:
If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.
If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.
Thanks very much.
On 2014/05/16 19:14:16, crawshaw wrote: > There needs to be some story for how this ...
10 years, 7 months ago
(2014-05-16 19:55:55 UTC)
#7
On 2014/05/16 19:14:16, crawshaw wrote:
> There needs to be some story for how this relates to a request-scoped context,
> i.e. http://www.gorillatoolkit.org/pkg/context
>
> It could be as simple as a note in the package doc that some future
> requestcontext package is planned, that given some common request scopes (e.g.
> *http.Request, or an RPC call object), returns a context.Context.
>
> https://codereview.appspot.com/99330045/diff/40001/context/context.go
> File context/context.go (right):
>
>
https://codereview.appspot.com/99330045/diff/40001/context/context.go#newcode61
> context/context.go:61: var keys = make(map[string]*Key)
> Why use *Key throughout instead of Key?
>
>
https://codereview.appspot.com/99330045/diff/40001/context/context.go#newcode168
> context/context.go:168: if c == nil {
> As you explicitly encourage people in the documentation to not use nil for a
> context, why check for it here?
>
>
https://codereview.appspot.com/99330045/diff/40001/context/context.go#newcode192
> context/context.go:192: // TODO returns the Background context. Code should
use
> context.TODO when it's
> Perhaps // TODO returns an ambient background context.
>
> There could be some debugging value in giving the ctx type a String method,
> which can print "context.Background" or "context.TODO" or a more helpful
message
> about the context being done, or information about its deadline.
Added a note in the package docs about *http.Request and similar.
Issue 99330045: code review 99330045: go.net/context: define the Context type, which supports...
(Closed)
Created 10 years, 7 months ago by Sameer Ajmani
Modified 10 years, 7 months ago
Reviewers:
Base URL:
Comments: 14