Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4143)

Issue 9921044: code review 9921044: go.crypto/ssh: fix test breakage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by dfc
Modified:
10 years, 10 months ago
Reviewers:
kr
CC:
albert.strasheim, kr, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: fix test breakage Followup CL for 9711043. The order that CombinedOutput returns data captured from stdout/stderr is not specified, so we have to test both variants. Thanks to fullung for the bug report.

Patch Set 1 #

Patch Set 2 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ssh/session_test.go View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4
dfc
Hello fullung@gmail.com, kr@xph.us (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
10 years, 10 months ago (2013-06-01 00:05:51 UTC) #1
dfc
On 2013/06/01 00:05:51, dfc wrote: > Hello mailto:fullung@gmail.com, mailto:kr@xph.us (cc: mailto:golang-dev@googlegroups.com), > > I'd like ...
10 years, 10 months ago (2013-06-01 00:06:24 UTC) #2
kr
LGTM Thanks!
10 years, 10 months ago (2013-06-01 00:56:08 UTC) #3
dfc
10 years, 10 months ago (2013-06-01 00:58:12 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=7248f59503a8&repo=crypto ***

go.crypto/ssh: fix test breakage

Followup CL for 9711043. The order that CombinedOutput returns data captured
from stdout/stderr is not specified, so we have to test both variants.

Thanks to fullung for the bug report.

R=fullung, kr
CC=golang-dev
https://codereview.appspot.com/9921044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b