Issue 99180043: code review 99180043: C: add another email address for David Crawshaw

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 99180043: code review 99180043: C: add another email address for David Crawshaw (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by bradfitz

Modified:
10 years, 12 months ago

Reviewers:
gobot, crawshaw

CC:
crawshaw, golang-codereviews

Visibility:
Public.

Description

C: add another email address for David Crawshaw

Patch Set 1 #

Patch Set 2 : diff -r 299229ac4300 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 299229ac4300 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 299229ac4300 https://go.googlecode.com/hg/ #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	CONTRIBUTORS	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello crawshaw@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 12 months ago (2014-05-11 21:42:29 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=51abda6c4854 *** C: add another email address for David Crawshaw LGTM=crawshaw R=crawshaw ...

10 years, 12 months ago (2014-05-11 21:46:40 UTC) #3

gobot

10 years, 12 months ago (2014-05-12 13:51:38 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the freebsd-arm-cheney builder.
See http://build.golang.org/log/e534cff724810391221eadbe03c23e8096f3a843

Expand All Messages | Collapse All Messages