Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1326)

Issue 9915043: code review 9915043: compress/bzip2: faster decoding. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by remyoudompheng
Modified:
5 years ago
Reviewers:
agl1
CC:
golang-dev, dfc, bradfitz, agl1
Visibility:
Public.

Description

compress/bzip2: faster decoding. benchmark old ns/op new ns/op delta BenchmarkDecodeDigits 19451173 14347829 -26.24% BenchmarkDecodeTwain 57516800 42619978 -25.90% benchmark old MB/s new MB/s speedup BenchmarkDecodeDigits 2.22 3.01 1.36x BenchmarkDecodeTwain 2.17 2.93 1.35x

Patch Set 1 #

Patch Set 2 : diff -r 7bd52af9db1c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7bd52af9db1c https://go.googlecode.com/hg/ #

Total comments: 5

Patch Set 4 : diff -r 4e0de2c84cc1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -25 lines) Patch
M src/pkg/compress/bzip2/bit_reader.go View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/pkg/compress/bzip2/bzip2_test.go View 1 1 chunk +29 lines, -0 lines 0 comments Download
M src/pkg/compress/bzip2/huffman.go View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/pkg/compress/bzip2/move_to_front.go View 1 3 chunks +15 lines, -22 lines 0 comments Download
A src/pkg/compress/bzip2/testdata/Mark.Twain-Tom.Sawyer.txt.bz2 View 1 Binary file 0 comments Download
A src/pkg/compress/bzip2/testdata/e.txt.bz2 View 1 Binary file 0 comments Download

Messages

Total messages: 9
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
5 years ago (2013-05-31 20:11:53 UTC) #1
dfc
On 2013/05/31 20:11:53, remyoudompheng wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
5 years ago (2013-06-01 11:32:13 UTC) #2
remyoudompheng
Interesting results in linux/386 (Intel Core Duo T2300 1.66GHz) benchmark old ns/op new ns/op delta ...
5 years ago (2013-06-03 16:40:31 UTC) #3
bradfitz
Why are the testdata/*.bz2 files changing? On Fri, May 31, 2013 at 1:11 PM, <remyoudompheng@gmail.com> ...
5 years ago (2013-06-03 16:59:44 UTC) #4
remyoudompheng
On 2013/6/3 Brad Fitzpatrick <bradfitz@golang.org> wrote: > Why are the testdata/*.bz2 files changing? They didn't ...
5 years ago (2013-06-03 17:17:37 UTC) #5
agl1
https://codereview.appspot.com/9915043/diff/5001/src/pkg/compress/bzip2/bzip2_test.go File src/pkg/compress/bzip2/bzip2_test.go (right): https://codereview.appspot.com/9915043/diff/5001/src/pkg/compress/bzip2/bzip2_test.go#newcode185 src/pkg/compress/bzip2/bzip2_test.go:185: func BenchmarkDecodeDigits(b *testing.B) { benchmarkDecode(b, digits) } It seems ...
5 years ago (2013-06-03 17:49:36 UTC) #6
remyoudompheng
https://codereview.appspot.com/9915043/diff/5001/src/pkg/compress/bzip2/bzip2_test.go File src/pkg/compress/bzip2/bzip2_test.go (right): https://codereview.appspot.com/9915043/diff/5001/src/pkg/compress/bzip2/bzip2_test.go#newcode185 src/pkg/compress/bzip2/bzip2_test.go:185: func BenchmarkDecodeDigits(b *testing.B) { benchmarkDecode(b, digits) } On 2013/06/03 ...
5 years ago (2013-06-03 17:53:45 UTC) #7
agl1
LGTM. https://codereview.appspot.com/9915043/diff/5001/src/pkg/compress/bzip2/huffman.go File src/pkg/compress/bzip2/huffman.go (right): https://codereview.appspot.com/9915043/diff/5001/src/pkg/compress/bzip2/huffman.go#newcode41 src/pkg/compress/bzip2/huffman.go:41: bit, ok := br.TryReadBit() On 2013/06/03 17:53:45, remyoudompheng ...
5 years ago (2013-06-03 17:56:13 UTC) #8
remyoudompheng
5 years ago (2013-06-03 18:38:15 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=cf3ee583c568 ***

compress/bzip2: faster decoding.

benchmark                old ns/op    new ns/op    delta
BenchmarkDecodeDigits     19451173     14347829  -26.24%
BenchmarkDecodeTwain      57516800     42619978  -25.90%

benchmark                 old MB/s     new MB/s  speedup
BenchmarkDecodeDigits         2.22         3.01    1.36x
BenchmarkDecodeTwain          2.17         2.93    1.35x

R=golang-dev, dave, bradfitz, agl
CC=golang-dev
https://codereview.appspot.com/9915043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b