code review 9905043: misc/dashboard/builder: include $objtype in build envir...

misc/dashboard/builder: add environment variables for Plan 9

We require $objtype in make.rc and rc needs $path for finding commands.

Also include $cputype which we may use in the future.

[ality, 2013-05-31 17:38:35]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2013-05-31 18:06:51]

LGTM. Is there any other Plan 9 specific environment variable that need to
be passed down?

[ality, 2013-05-31 18:13:56]

minux <minux.ma@gmail.com> once said:
> LGTM. Is there any other Plan 9 specific environment variable that need to
> be passed down?

Both make.rc and run.rc reference $sysname but it will
only matter if someone is running on the 9vx virtual
machine. I think I'm the only one who has done this
since it requires lots of fixes to 9vx (that I haven't
yet made public).

  Anthony

[r, 2013-05-31 18:16:01]

LGTM

https://codereview.appspot.com/9905043/diff/5001/misc/dashboard/builder/main.go
File misc/dashboard/builder/main.go (right):

https://codereview.appspot.com/9905043/diff/5001/misc/dashboard/builder/main....
misc/dashboard/builder/main.go:39: "objtype",
might as well include cputype?

[ality, 2013-05-31 18:20:35]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[ality, 2013-05-31 18:26:25]

r@golang.org once said:
> misc/dashboard/builder/main.go:39: "objtype",
> might as well include cputype?

We don't yet use it but sure, sounds good.

I also added $path. rc depends on it.

  Anthony

[r, 2013-05-31 19:05:32]

LGTM

[ality, 2013-05-31 19:18:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=790c4ffd6d36 ***

misc/dashboard/builder: add environment variables for Plan 9

We require $objtype in make.rc and rc needs $path for finding commands.

Also include $cputype which we may use in the future.

R=golang-dev, minux.ma, r
CC=golang-dev
https://codereview.appspot.com/9905043