Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(172)

Issue 9899043: code review 9899043: spec: better wording re: receiving from closed channels (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by gri
Modified:
12 years ago
Reviewers:
r
CC:
r, golang-dev
Visibility:
Public.

Description

spec: better wording re: receiving from closed channels As suggested by ej@evanjones.ca. Fixes issue 5604.

Patch Set 1 #

Total comments: 4

Patch Set 2 : diff -r fd791d51e476 https://code.google.com/p/go #

Patch Set 3 : diff -r fd791d51e476 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M doc/go_spec.html View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6
gri
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years ago (2013-05-31 16:22:23 UTC) #1
r
LGTM https://codereview.appspot.com/9899043/diff/1/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/9899043/diff/1/doc/go_spec.html#newcode3305 doc/go_spec.html:3305: immediately returns the element type's <a href="#The_zero_value">zero value</a>. ...
12 years ago (2013-05-31 17:05:07 UTC) #2
r
https://codereview.appspot.com/9899043/diff/1/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/9899043/diff/1/doc/go_spec.html#newcode3305 doc/go_spec.html:3305: immediately returns the element type's <a href="#The_zero_value">zero value</a>. of ...
12 years ago (2013-05-31 17:06:47 UTC) #3
gri
PTAL https://codereview.appspot.com/9899043/diff/1/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/9899043/diff/1/doc/go_spec.html#newcode3305 doc/go_spec.html:3305: immediately returns the element type's <a href="#The_zero_value">zero value</a>. ...
12 years ago (2013-05-31 17:24:22 UTC) #4
r
LGTM
12 years ago (2013-05-31 18:18:40 UTC) #5
gri
12 years ago (2013-05-31 18:21:40 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=e86ab7e59e50 ***

spec: better wording re: receiving from closed channels

As suggested by ej@evanjones.ca.

Fixes issue 5604.

R=r
CC=golang-dev
https://codereview.appspot.com/9899043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b