Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(797)

Issue 9895043: code review 9895043: cmd/cgo: use gcc_struct attribute for packed structs to... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by minux1
Modified:
6 years, 4 months ago
Reviewers:
iant
CC:
iant, dfc, gobot, golang-dev
Visibility:
Public.

Description

cmd/cgo: use gcc_struct attribute for packed structs to work around GCC PR52991. Fixes issue 5603.

Patch Set 1 #

Patch Set 2 : diff -r fd791d51e476 https://code.google.com/p/go #

Patch Set 3 : diff -r fd791d51e476 https://code.google.com/p/go #

Patch Set 4 : diff -r fd791d51e476 https://code.google.com/p/go #

Patch Set 5 : diff -r 4e0de2c84cc1 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 6 : diff -r 4aa7943034c5 https://code.google.com/p/go #

Patch Set 7 : diff -r 4aa7943034c5 https://code.google.com/p/go #

Patch Set 8 : diff -r 5a3640ad42c3 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M misc/cgo/test/cgo_test.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A misc/cgo/test/issue5603.go View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M src/cmd/cgo/doc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/cgo/out.go View 1 2 3 4 5 6 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 4 months ago (2013-05-31 15:43:19 UTC) #1
gobot
R=iant (assigned by dfc)
6 years, 4 months ago (2013-06-02 04:08:19 UTC) #2
minux1
gentle ping.
6 years, 4 months ago (2013-06-03 17:39:50 UTC) #3
iant
https://codereview.appspot.com/9895043/diff/10001/src/cmd/cgo/out.go File src/cmd/cgo/out.go (right): https://codereview.appspot.com/9895043/diff/10001/src/cmd/cgo/out.go#newcode488 src/cmd/cgo/out.go:488: // Use __gcc_struct__ to work around http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52991 To reference ...
6 years, 4 months ago (2013-06-03 18:16:02 UTC) #4
dfc
On 2013/06/03 18:16:02, iant wrote: > https://codereview.appspot.com/9895043/diff/10001/src/cmd/cgo/out.go > File src/cmd/cgo/out.go (right): > > https://codereview.appspot.com/9895043/diff/10001/src/cmd/cgo/out.go#newcode488 > ...
6 years, 4 months ago (2013-06-06 12:37:37 UTC) #5
minux1
PTAL. All comments are addressed. Sorry for the delay, just completed my dissertation defense.
6 years, 4 months ago (2013-06-07 09:01:51 UTC) #6
dfc
Congratulations. I hope it was a success. On 07/06/2013, at 19:01, minux.ma@gmail.com wrote: > PTAL. ...
6 years, 4 months ago (2013-06-07 09:07:19 UTC) #7
dfc
On 2013/06/07 09:07:19, dfc wrote: > Congratulations. I hope it was a success. > > ...
6 years, 4 months ago (2013-06-07 11:01:29 UTC) #8
iant
LGTM Thanks, and congratulations on the dissertation.
6 years, 4 months ago (2013-06-07 13:29:10 UTC) #9
minux1
6 years, 4 months ago (2013-06-09 14:06:51 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=ae83f4b0aa29 ***

cmd/cgo: use gcc_struct attribute for packed structs to work around GCC PR52991.
Fixes issue 5603.

R=iant, dave
CC=gobot, golang-dev
https://codereview.appspot.com/9895043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b