code review 98880043: html: fix small typo

html: fix small typo

[rh, 2014-05-01 00:32:11]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2014-05-01 18:53:40]

LGTM

[adg, 2014-05-01 18:53:50]

LGTM

[crawshaw, 2014-05-01 18:54:34]

LGTM

[r, 2014-05-01 18:55:23]

LGTM

[bradfitz, 2014-05-01 18:56:37]

LGTM



On Wed, Apr 30, 2014 at 5:32 PM, <robert.hencke@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> html: fix small typo
>
> Please review this at https://codereview.appspot.com/98880043/
>
> Affected files (+1, -1 lines):
>   M src/pkg/html/template/js.go
>
>
> Index: src/pkg/html/template/js.go
> ===================================================================
> --- a/src/pkg/html/template/js.go
> +++ b/src/pkg/html/template/js.go
> @@ -99,7 +99,7 @@
>         return jsCtxDivOp
>  }
>
> -// regexPrecederKeywords is a set of reserved JS keywords that can
> precede a
> +// regexpPrecederKeywords is a set of reserved JS keywords that can
> precede a
>  // regular expression in JS source.
>  var regexpPrecederKeywords = map[string]bool{
>         "break":      true,
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[francesc, 2014-05-01 18:56:38]

On 2014/05/01 18:55:23, r wrote:
> LGTM

LGTM

[nigeltao, 2014-05-01 18:56:38]

thetruthofthematter LGTM.

[r, 2014-05-01 18:56:48]

Waiting for rsc

[Sameer Ajmani, 2014-05-01 18:56:53]

LGTM

[iant, 2014-05-01 18:57:34]

LGTM

[robsc, 2014-05-01 18:59:14]

On 2014/05/01 18:57:34, iant wrote:
> LGTM

LGTM

[djd, 2014-05-01 19:00:38]

LGTM

[michael.j.fromberger, 2014-05-01 19:00:40]

LGTM

[gmlewis1, 2014-05-01 19:01:23]

LGTM

[adonovan, 2014-05-01 19:02:35]

On 2014/05/01 19:01:23, gmlewis1 wrote:
> LGTM

LGTM, but the approval of the preceders should suffice.

[rsc, 2014-05-01 19:03:21]

LGTM

[rh, 2014-05-01 19:58:23]

Ha - this made my day.  Thanks for all the reviews.

[r, 2014-05-01 20:29:38]

*** Submitted as https://code.google.com/p/go/source/detail?r=b0443478e712 ***

html: fix small typo

LGTM=dsymonds, adg, crawshaw, r, bradfitz, campoy, nigeltao, sameer, iant,
robsc, djd, michael.j.fromberger, gmlewis, adonovan, rsc
R=golang-codereviews, dsymonds, adg, crawshaw, r, nigeltao, sameer, iant, robsc,
djd, michael.j.fromberger, gmlewis, adonovan, rsc
CC=golang-codereviews
https://codereview.appspot.com/98880043

Committer: Rob Pike <r@golang.org>

[gobot, 2014-05-01 20:40:59]

This CL appears to have broken the linux-amd64-farce builder.
See http://build.golang.org/log/64dc1be0c2e0c9e50381d1577511a2d939e19eba

[bradfitz, 2014-05-01 20:41:26]

I think we're going to have to roll this back.
 On May 1, 2014 4:41 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the linux-amd64-farce builder.
> See http://build.golang.org/log/64dc1be0c2e0c9e50381d1577511a2d939e19eba
>
> https://codereview.appspot.com/98880043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[djd, 2014-05-01 20:45:30]

LGTM

[rh, 2014-05-01 20:59:00]

On 2014/05/01 20:41:26, bradfitz wrote:
> I think we're going to have to roll this back.

It may have been a bit too ambitious of a change.