Issue 9869045: code review 9869045: runtime: set MSpan.limit properly for large spans.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9869045: code review 9869045: runtime: set MSpan.limit properly for large spans. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by khr

Modified:
12 years, 1 month ago

Reviewers:
dvyukov

CC:
golang-dev, dvyukov

Visibility:
Public.

Description

runtime: set MSpan.limit properly for large spans. Then use the limit to make sure MHeap_LookupMaybe & inlined copies don't return a span if the pointer is beyond the limit. Use this fact to optimize all call sites.

Patch Set 1 #

Patch Set 2 : diff -r 8c800027d5a6 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 8c800027d5a6 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 8c800027d5a6 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 8c800027d5a6 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 8c800027d5a6 https://khr%40golang.org@code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -16 lines)			Patch
M	src/pkg/runtime/malloc.goc	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/pkg/runtime/mgc0.c	View		3 chunks	+2 lines, -8 lines	0 comments	Download
M	src/pkg/runtime/mheap.c	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

khr

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

12 years, 1 month ago (2013-05-30 22:42:03 UTC) #1

khr

12 years, 1 month ago (2013-05-31 04:32:24 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=85353b4dc2d4 ***

runtime: set MSpan.limit properly for large spans.
Then use the limit to make sure MHeap_LookupMaybe & inlined
copies don't return a span if the pointer is beyond the limit.
Use this fact to optimize all call sites.

R=golang-dev, dvyukov
CC=golang-dev
https://codereview.appspot.com/9869045

Expand All Messages | Collapse All Messages