ec2: support RunInstances with BlockDeviceMappings

ec2: support RunInstances with BlockDeviceMappings



https://code.launchpad.net/~niemeyer/goamz/run-with-devices/+merge/166428

(do not edit description out of merge proposal)

[niemeyer, 2013-05-30 03:09:05]

Please take a look.

[niemeyer, 2013-06-02 19:51:12]

ping

[dfc, 2013-06-04 02:21:57]

LGTM. Sorry for the delay.

[dfc, 2013-06-04 02:23:13]

https://codereview.appspot.com/9860044/diff/1/ec2/ec2.go
File ec2/ec2.go (right):

https://codereview.appspot.com/9860044/diff/1/ec2/ec2.go#newcode457
ec2/ec2.go:457: VolumeSize          int64  `xml:"ebs>volumeSize"` // Size is
given in GB
could this be uin64 ? Does a negative size mean anything in ec2 land ?

https://codereview.appspot.com/9860044/diff/1/ec2/ec2.go#newcode461
ec2/ec2.go:461: IOPS int64 `xml:"ebs>iops"`
same, negative iops doesn't make a lot of sense.

[niemeyer, 2013-06-04 12:52:08]

https://codereview.appspot.com/9860044/diff/1/ec2/ec2.go
File ec2/ec2.go (right):

https://codereview.appspot.com/9860044/diff/1/ec2/ec2.go#newcode457
ec2/ec2.go:457: VolumeSize          int64  `xml:"ebs>volumeSize"` // Size is
given in GB
On 2013/06/04 02:23:13, dfc wrote:
> could this be uin64 ? Does a negative size mean anything in ec2 land ?

I would actually prefer to see it as "int", were not for compatibility reasons.
For a while, mapping 2^31 **GB** won't be realistic.

https://codereview.appspot.com/9860044/diff/1/ec2/ec2.go#newcode461
ec2/ec2.go:461: IOPS int64 `xml:"ebs>iops"`
On 2013/06/04 02:23:13, dfc wrote:
> same, negative iops doesn't make a lot of sense.

Neither does negative indexes/length/capacity on slices, but they're signed
still. In general, unless there's a reason for things to be unsigned, I prefer
to keep them signed as well.

[niemeyer, 2013-10-04 17:07:01]

Please take a look.

[natefinch, 2013-10-04 17:11:20]

On 2013/10/04 17:07:01, niemeyer wrote:
> Please take a look.

LGTM

[niemeyer, 2013-10-04 17:13:10]

*** Submitted:

ec2: support RunInstances with BlockDeviceMappings

R=dfc, nate.finch
CC=
https://codereview.appspot.com/9860044