Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(190)

Issue 9853050: code review 9853050: go.crypto/ssh: implement challenge/response auth (RFC 4... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by hanwen-google
Modified:
8 years, 4 months ago
Reviewers:
agl1
CC:
dfc, agl1, gobot, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: implement keyboard-interactive auth (RFC 4256), both on client and server-side.

Patch Set 1 #

Patch Set 2 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Total comments: 26

Patch Set 5 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Patch Set 7 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Total comments: 16

Patch Set 8 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Patch Set 9 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Patch Set 10 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Total comments: 1

Patch Set 11 : diff -r b5f1a3f28dce https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -0 lines) Patch
M ssh/client_auth.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +117 lines, -0 lines 0 comments Download
M ssh/client_auth_test.go View 1 2 3 4 5 6 7 8 3 chunks +60 lines, -0 lines 0 comments Download
M ssh/common.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
M ssh/messages.go View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M ssh/server.go View 1 2 3 4 5 6 7 4 chunks +76 lines, -0 lines 0 comments Download

Messages

Total messages: 8
hanwen-google
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
8 years, 4 months ago (2013-05-31 22:22:17 UTC) #1
gobot
R=dfc (assigned by dfc)
8 years, 4 months ago (2013-06-01 02:07:08 UTC) #2
dfc
+cc agl, I'm happy with the code, but I have no experience with this authentication ...
8 years, 4 months ago (2013-06-06 12:04:42 UTC) #3
hanwen-google
thanks for the review! All addressed. https://codereview.appspot.com/9853050/diff/7001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/9853050/diff/7001/ssh/client_auth.go#newcode383 ssh/client_auth.go:383: questions []string, echos ...
8 years, 4 months ago (2013-06-06 13:33:07 UTC) #4
agl1
LGTM https://codereview.appspot.com/9853050/diff/23001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/9853050/diff/23001/ssh/client_auth.go#newcode382 ssh/client_auth.go:382: // 3.3 details how the UI should behave ...
8 years, 4 months ago (2013-06-06 14:22:13 UTC) #5
hanwen-google
https://codereview.appspot.com/9853050/diff/23001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/9853050/diff/23001/ssh/client_auth.go#newcode382 ssh/client_auth.go:382: // 3.3 details how the UI should behave for ...
8 years, 4 months ago (2013-06-06 14:37:17 UTC) #6
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=c510c3e5067d&repo=crypto *** go.crypto/ssh: implement keyboard-interactive auth (RFC 4256), both on client and ...
8 years, 4 months ago (2013-06-06 14:44:20 UTC) #7
hanwen-google
8 years, 4 months ago (2013-06-06 15:47:31 UTC) #8
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b