Issue 98460046: Fix bootstrap for custom metadata

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98460046: Fix bootstrap for custom metadata

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by wallyworld

Modified:
9 years, 11 months ago

Reviewers:
mp+220561, axw

Visibility:
Public.

Description

Fix bootstrap for custom metadata When bootstrap was used with --metadata-source, the bootstrap aborted for private clouds without any existing image metadata. This is because the initialisation of the constraints validator tried to look up image metadata to get the supported achitectures. The solution is to defer constraints validation when --metadata-source is specified. https://code.launchpad.net/~wallyworld/juju-core/upload-custom-metadata-sooner/+merge/220561 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -9 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/bootstrap.go	View	3 chunks	+25 lines, -9 lines	0 comments	Download
M	cmd/juju/bootstrap_test.go	View	1 chunk	+30 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

9 years, 11 months ago (2014-05-22 05:29:03 UTC) #2

LGTM

https://codereview.appspot.com/98460046/diff/1/cmd/juju/bootstrap_test.go
File cmd/juju/bootstrap_test.go (right):

https://codereview.appspot.com/98460046/diff/1/cmd/juju/bootstrap_test.go#new...
cmd/juju/bootstrap_test.go:507: validateCalled := 0
It's probably too excruciating, but it would be nice to test the order of
operations. i.e. check that validation occurs after uploading metadata.

Expand All Messages | Collapse All Messages