Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(359)

Issue 98460044: Remove thirdparty/pbkdf2

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by dave
Modified:
10 years ago
Reviewers:
axw, mp+220341
Visibility:
Public.

Description

Remove thirdparty/pbkdf2 In preparation for the migration to github remove the private copy of pbkdf2. It is probable that when this package was added, somewhere around 18 months ago, we did not have godeps or a established way of managing dependencies, so vendoring the package made sense at the time. The only differences between our privat copy and the upstream is our inclusion of our note that the package is a fork. ubuntu@winton-02:~$ diff -u ~/src/launchpad.net/juju-core/thirdparty/pbkdf2/pbkdf2.go /home/ubuntu/src/code.google.com/p/go.crypto/pbkdf2/pbkdf2.go --- /home/ubuntu/src/launchpad.net/juju-core/thirdparty/pbkdf2/pbkdf2.go 2014-05-21 00:46:49.130817000 +0000 +++ /home/ubuntu/src/code.google.com/p/go.crypto/pbkdf2/pbkdf2.go 2014-05-21 00:46:54.275885894 +0000 @@ -1,5 +1,3 @@ -// Original package at code.google.com/p/go.crypto/pbkdf2 - // Copyright 2012 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. ubuntu@winton-02:~$ diff -u ~/src/launchpad.net/juju-core/thirdparty/pbkdf2/pbkdf2_test.go /home/ubuntu/src/code.google.com/p/go.crypto/pbkdf2/pbkdf2_test.go https://code.launchpad.net/~dave-cheney/juju-core/179-remove-thirdparty-pbkdf2-dependency/+merge/220341 Requires: https://code.launchpad.net/~dave-cheney/juju-core/178-update-errgo-and-loggo-dependencies/+merge/220340 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove thirdparty/pbkdf2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -239 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/package_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
D thirdparty/pbkdf2/pbkdf2.go View 1 chunk +0 lines, -79 lines 0 comments Download
D thirdparty/pbkdf2/pbkdf2_test.go View 1 chunk +0 lines, -157 lines 0 comments Download
M utils/fslock/package_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/password.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dave_cheney.net
Please take a look.
10 years ago (2014-05-21 01:33:16 UTC) #1
axw
On 2014/05/21 01:33:16, dfc wrote: > Please take a look. LGTM
10 years ago (2014-05-21 01:39:39 UTC) #2
dave_cheney.net
10 years ago (2014-05-21 02:36:19 UTC) #3
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b