agent/mongo: improve TestEnsureAdminUser

agent/mongo: improve TestEnsureAdminUser

Several improvements in an efford to get
TestEnsureAdminUser to stop failing CI.

 - Call the BaseSuite's SetUpTest
 - Log the error Login
 - Mock out the starting of mongod with --noauth.
   The existing code actually starts up mongod
   again inside the test, with the same port as
   the still-running server. This *may* be what
   caused issues in CI, but I could never reproduce
   it.
 - Extend TestEnsureAdminUser to check that mongod
   is/isn't started/stopped/etc.

Possibly fixes lp:1319225
(I have been unable to reproduce the failure)

https://code.launchpad.net/~axwalk/juju-core/lp1319225-testensureadminuser/+merge/220204

(do not edit description out of merge proposal)

[axw, 2014-05-20 08:10:54]

Please take a look.

[fwereade, 2014-05-20 08:17:33]

LGTM, let's see if it helps :).

https://codereview.appspot.com/98440043/diff/1/agent/mongo/upgrade_test.go
File agent/mongo/upgrade_test.go (right):

https://codereview.appspot.com/98440043/diff/1/agent/mongo/upgrade_test.go#ne...
agent/mongo/upgrade_test.go:4: package mongo
Not loving the in-package tests here. What led to this, do you know?

[axw, 2014-05-20 08:18:56]

https://codereview.appspot.com/98440043/diff/1/agent/mongo/upgrade_test.go
File agent/mongo/upgrade_test.go (right):

https://codereview.appspot.com/98440043/diff/1/agent/mongo/upgrade_test.go#ne...
agent/mongo/upgrade_test.go:4: package mongo
On 2014/05/20 08:17:33, fwereade wrote:
> Not loving the in-package tests here. What led to this, do you know?

Dunno, I'll see if I can unpick it quickly before landing.

[axw, 2014-05-20 08:43:52]

Please take a look.