Issue 9840043: code review 9840043: cmd/5a, cmd/dist, runtime: support m/g in the assembler...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9840043: code review 9840043: cmd/5a, cmd/dist, runtime: support m/g in the assembler... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by minux1

Modified:
12 years ago

Reviewers:
khr

CC:
golang-dev, khr, rsc

Visibility:
Public.

Description

cmd/5a, cmd/dist, runtime: support m/g in the assembler, drop support for R9/R10 to avoid unintentionally clobber R9/R10. Thanks Lucio for the suggestion. PS: yes, this could be considered a big change (but not an API change), but as it turns out even temporarily changes R9/R10 in user code is unsafe and leads to very hard to diagnose problems later, better to disable using R9/R10 when the user first uses it. See CL 6300043 and CL 6305100 for two problems caused by misusing R9/R10.

Patch Set 1 #

Patch Set 2 : diff -r e84e7204b01b https://code.google.com/p/go/ #

Patch Set 3 : diff -r c658ed1b4459 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 81ccdb178fd7 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 4ae1bb001f75 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 4ae1bb001f75 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -28 lines)			Patch
M	doc/go1.2.txt	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/5a/lex.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/dist/buildruntime.c	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/cgo/asm_arm.s	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/vlop_arm.s	View	1	8 chunks	+22 lines, -22 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-05-28 17:59:25 UTC) #1

khr

On 2013/05/28 17:59:25, minux wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

12 years ago (2013-05-28 19:39:24 UTC) #2

minux1

added a line to doc/go1.2.txt will wait some time before submitting.

12 years ago (2013-05-28 19:46:01 UTC) #3

minux1

12 years ago (2013-05-29 19:04:03 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=41702da0dcc4 ***

cmd/5a, cmd/dist, runtime: support m/g in the assembler, drop support for R9/R10
to avoid unintentionally clobber R9/R10.
Thanks Lucio for the suggestion.

PS: yes, this could be considered a big change (but not an API change), but
as it turns out even temporarily changes R9/R10 in user code is unsafe and
leads to very hard to diagnose problems later, better to disable using R9/R10
when the user first uses it.
See CL 6300043 and CL 6305100 for two problems caused by misusing R9/R10.

R=golang-dev, khr, rsc
CC=golang-dev
https://codereview.appspot.com/9840043

Expand All Messages | Collapse All Messages