Issue 98390047: Don't die if an option has no type.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98390047: Don't die if an option has no type.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by bac

Modified:
9 years, 11 months ago

Reviewers:
mp+220286, Marco Ceppi

Visibility:
Public.

Description

Don't die if an option has no type. If a config option doesn't specify a type, a warning was issued but the process failed with KeyError. This fix allows it to proceed, using 'string' if not type is given. This bug affects charmworld ingest, so getting it released soonish would be great. https://code.launchpad.net/~bac/charm-tools/1321316/+merge/220286 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Don't die if an option has no type. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmtools/charms.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/test_charm_proof.py	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bac

9 years, 11 months ago (2014-05-20 15:21:53 UTC) #3

*** Submitted:

Don't die if an option has no type.

If a config option doesn't specify a type, a warning was issued
but the process failed with KeyError.  This fix allows it to proceed, using
'string' if not type is given.

This bug affects charmworld ingest, so getting it released soonish would be
great.

R=Marco Ceppi
CC=
https://codereview.appspot.com/98390047

Expand All Messages | Collapse All Messages