Create a redirecting http server

Create a redirecting http server

For 'make prod' and 'make devel', the use of the SimpleHTTPServer fails if a
path not represented on the file server is entered directly into the address
field.  This situation occurs if one manually enters a namespace
(e.g. ':gui:') or uses a feature flag.

This branch adds a small wrapper python program that returns '/index.html'
if the path does not exist on the file system.  This approach isn't perfect as
you get shunted back to the front page.

https://code.launchpad.net/~bac/juju-gui/httpserver/+merge/166092

(do not edit description out of merge proposal)

[bac, 2013-05-28 16:14:32]

Please take a look.

[benji, 2013-05-28 16:45:13]

Thanks for doing this.  The test servers not doing this has irritated me more
than once.

I found a couple of small issues, but once you address them to your satisfaction
I'm sure this will be good to land.


LGTM-ly y'rs
Benji

https://codereview.appspot.com/9836043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/9836043/diff/1/Makefile#newcode453
Makefile:453: #cd build-prod && python -m SimpleHTTPServer 8888
We probably don't want this commented-out line.  Right?

https://codereview.appspot.com/9836043/diff/1/Makefile#newcode454
Makefile:454: cd build-prod && python ../bin/http_server.py 8888
I would put this in a subshell so the directory isn't switched for any other
rules that are run.  I.e., 

    (cd build-prod && python ../bin/http_server.py 8888)

https://codereview.appspot.com/9836043/diff/1/bin/http_server.py
File bin/http_server.py (right):

https://codereview.appspot.com/9836043/diff/1/bin/http_server.py#newcode29
bin/http_server.py:29: # RedirectingHTTPRequestHandler
I'm not sure what function this comment serves.  I would love to be enlightened.

https://codereview.appspot.com/9836043/diff/1/bin/http_server.py#newcode43
bin/http_server.py:43: ServerClass = BaseHTTPServer.HTTPServer):
It is customary to not have spaces around the equal signs when defining default
arguments.

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py
File test/test_http_server.py (right):

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py#newcode30
test/test_http_server.py:30: 
Missing newline.

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py#newcode38
test/test_http_server.py:38: 
Another missing newline.

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py#newcode96
test/test_http_server.py:96: # Can serve up an existing path.
This comment doesn't seem quite right.

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py#newcod...
test/test_http_server.py:108: 
I found one of the missing newlines!

[bac, 2013-05-28 18:15:31]

Please take a look.

https://codereview.appspot.com/9836043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/9836043/diff/1/Makefile#newcode453
Makefile:453: #cd build-prod && python -m SimpleHTTPServer 8888
On 2013/05/28 16:45:13, benji wrote:
> We probably don't want this commented-out line.  Right?

Done.

https://codereview.appspot.com/9836043/diff/1/Makefile#newcode454
Makefile:454: cd build-prod && python ../bin/http_server.py 8888
On 2013/05/28 16:45:13, benji wrote:
> I would put this in a subshell so the directory isn't switched for any other
> rules that are run.  I.e., 
> 
>     (cd build-prod && python ../bin/http_server.py 8888)

Done.

https://codereview.appspot.com/9836043/diff/1/bin/http_server.py
File bin/http_server.py (right):

https://codereview.appspot.com/9836043/diff/1/bin/http_server.py#newcode29
bin/http_server.py:29: # RedirectingHTTPRequestHandler
On 2013/05/28 16:45:13, benji wrote:
> I'm not sure what function this comment serves.  I would love to be
enlightened.

Done.

https://codereview.appspot.com/9836043/diff/1/bin/http_server.py#newcode43
bin/http_server.py:43: ServerClass = BaseHTTPServer.HTTPServer):
On 2013/05/28 16:45:13, benji wrote:
> It is customary to not have spaces around the equal signs when defining
default
> arguments.

Done.

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py
File test/test_http_server.py (right):

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py#newcode30
test/test_http_server.py:30: 
On 2013/05/28 16:45:13, benji wrote:
> Missing newline.

Done.

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py#newcode38
test/test_http_server.py:38: 
On 2013/05/28 16:45:13, benji wrote:
> Another missing newline.

Done.

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py#newcode96
test/test_http_server.py:96: # Can serve up an existing path.
On 2013/05/28 16:45:13, benji wrote:
> This comment doesn't seem quite right.

Done.

https://codereview.appspot.com/9836043/diff/1/test/test_http_server.py#newcod...
test/test_http_server.py:108: 
On 2013/05/28 16:45:13, benji wrote:
> I found one of the missing newlines!

Done.

[gary.poster, 2013-05-28 20:10:33]

LGTM with trivial.  Thank you!

Gary

https://codereview.appspot.com/9836043/diff/6002/bin/http_server.py
File bin/http_server.py (right):

https://codereview.appspot.com/9836043/diff/6002/bin/http_server.py#newcode29
bin/http_server.py:29: class
RedirectingHTTPRequestHandler(SimpleHTTPRequestHandler):
Technically, this isn't redirecting but rewriting, right?  IOW, the browser does
not know that they are being served index.html, it's just that index.html is
everywhere.  I'd suggest changing it if I am right simply because it confused
me.

[bac, 2013-05-28 20:23:17]

*** Submitted:

Create a redirecting http server

For 'make prod' and 'make devel', the use of the SimpleHTTPServer fails if a
path not represented on the file server is entered directly into the address
field.  This situation occurs if one manually enters a namespace
(e.g. ':gui:') or uses a feature flag.

This branch adds a small wrapper python program that returns '/index.html'
if the path does not exist on the file system.  This approach isn't perfect as
you get shunted back to the front page.

R=benji, gary.poster
CC=
https://codereview.appspot.com/9836043