Issue 9834046: code review 9834046: go.net/ipv6: drop unnecessary constant conversions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9834046: code review 9834046: go.net/ipv6: drop unnecessary constant conversions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by mikio

Modified:
11 years, 9 months ago

Reviewers:
dave

CC:
dave_cheney.net, golang-dev

Visibility:
Public.

Description

go.net/ipv6: drop unnecessary constant conversions Update issue 5538

Patch Set 1 : diff -r cdb33701d523 https://code.google.com/p/go.net #

Patch Set 2 : diff -r f6eadd030a9d https://code.google.com/p/go.net #

Patch Set 3 : diff -r f6eadd030a9d https://code.google.com/p/go.net #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	ipv6/sockopt_rfc3493_windows.go	View		8 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 9 months ago (2013-06-15 04:43:10 UTC) #1

dave_cheney.net

On 2013/06/15 04:43:10, mikio wrote: > Hello mailto:dave@cheney.net (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

11 years, 9 months ago (2013-06-15 08:43:43 UTC) #2

mikio

11 years, 9 months ago (2013-06-15 09:34:20 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=da2eb5dd9ea9&repo=net ***

go.net/ipv6: drop unnecessary constant conversions

Update issue 5538

R=dave
CC=golang-dev
https://codereview.appspot.com/9834046

Expand All Messages | Collapse All Messages