Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 9822043: code review 9822043: undo CL 9805043 / 776aba85ece8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by dvyukov
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev
Visibility:
Public.

Description

undo CL 9805043 / 776aba85ece8 multiple failures on amd64 ««« original CL description runtime: introduce helper persistentalloc() function It is a caching wrapper around SysAlloc() that can allocate small chunks. Use it for symtab allocations. Reduces number of symtab walks from 4 to 3 (reduces buildfuncs time from 10ms to 7.5ms on a large binary, reduces initial heap size by 680K on the same binary). Also can be used for type info allocation, itab allocation. There are also several places in GC where we do the same thing, they can be changed to use persistentalloc(). Also can be used in FixAlloc, because each instance of FixAlloc allocates in 128K regions, which is too eager. R=golang-dev, daniel.morsing, khr CC=golang-dev https://codereview.appspot.com/9805043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 598c883c08b8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 598c883c08b8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 598c883c08b8 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -55 lines) Patch
M src/pkg/runtime/malloc.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/runtime/malloc.goc View 1 1 chunk +0 lines, -47 lines 0 comments Download
M src/pkg/runtime/symtab.c View 1 6 chunks +25 lines, -7 lines 0 comments Download

Messages

Total messages: 2
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years, 1 month ago (2013-05-28 07:13:19 UTC) #1
dvyukov
12 years, 1 month ago (2013-05-28 07:15:09 UTC) #2
*** Submitted as https://code.google.com/p/go/source/detail?r=7e6f043f2000 ***

undo CL 9805043 / 776aba85ece8

multiple failures on amd64

««« original CL description
runtime: introduce helper persistentalloc() function
It is a caching wrapper around SysAlloc() that can allocate small chunks.
Use it for symtab allocations. Reduces number of symtab walks from 4 to 3
(reduces buildfuncs time from 10ms to 7.5ms on a large binary,
reduces initial heap size by 680K on the same binary).
Also can be used for type info allocation, itab allocation.
There are also several places in GC where we do the same thing,
they can be changed to use persistentalloc().
Also can be used in FixAlloc, because each instance of FixAlloc allocates
in 128K regions, which is too eager.

R=golang-dev, daniel.morsing, khr
CC=golang-dev
https://codereview.appspot.com/9805043
»»»

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/9822043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b