Issue 98190043: PS email list logic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98190043: PS email list logic

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by prannoysircar0325

Modified:
9 years, 11 months ago

Reviewers:
mail2coolgarg

Base URL:
https://immpandroid.unfuddle.com/svn/immpandroid_android/spfaq/

Visibility:
Public.

More Reviews

Description

PS email list logic

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -7 lines)			Patch
M	AndroidManifest.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	res/values/strings.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/app/shoppoke/faq/qa/QAAdeptar.java	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	src/app/shoppoke/faq/storedetail/SmsAndCallHistoryHandler.java	View	5 chunks	+30 lines, -2 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

mail2coolgarg

9 years, 11 months ago (2014-05-10 11:55:13 UTC) #1

fix the minor comment and commit.

https://codereview.appspot.com/98190043/diff/1/src/app/shoppoke/faq/qa/QAAdep...
File src/app/shoppoke/faq/qa/QAAdeptar.java (right):

https://codereview.appspot.com/98190043/diff/1/src/app/shoppoke/faq/qa/QAAdep...
src/app/shoppoke/faq/qa/QAAdeptar.java:103:
convertView.findViewById(R.id.ivShare).setVisibility(
use options here.

https://codereview.appspot.com/98190043/diff/1/src/app/shoppoke/faq/storedeta...
File src/app/shoppoke/faq/storedetail/SmsAndCallHistoryHandler.java (right):

https://codereview.appspot.com/98190043/diff/1/src/app/shoppoke/faq/storedeta...
src/app/shoppoke/faq/storedetail/SmsAndCallHistoryHandler.java:126: case 0:
this switch is errorprone, since which value will be dynamic

sms and phone will not always be there.

you dont bother about it. I will fix it later.

Expand All Messages | Collapse All Messages