Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(875)

Issue 98040043: bzr: fix a test about paths

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by jameinel
Modified:
6 years, 4 months ago
Reviewers:
mp+218587, fwereade
Visibility:
Public.

Description

bzr: fix a test about paths When bzr looks up the root of a branch, it expands symlinks to get the 'canonical' path. On Mac OS X, /tmp and /var are actually symlinks to /private/tmp and /private/var which broke the tests. So just EvalSymlinks on the path and it works again. https://code.launchpad.net/~jameinel/juju-core/darwin-tests/+merge/218587 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M bzr/bzr_test.go View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
6 years, 4 months ago (2014-05-07 10:42:07 UTC) #1
fwereade
6 years, 4 months ago (2014-05-07 12:16:05 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b