Issue 97970045: code review 97970045: go.tools/netutil: don't run test on versions of Go prio...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 97970045: code review 97970045: go.tools/netutil: don't run test on versions of Go prio... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by adg

Modified:
10 years, 11 months ago

Reviewers:
mikio

CC:
mikio, minux1, golang-codereviews

Visibility:
Public.

Description

go.net/netutil: don't run test on versions of Go prior to 1.3

Patch Set 1 #

Patch Set 2 : diff -r 88fa30947066 https://code.google.com/p/go.net #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	netutil/listen_test.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello mikio (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 11 months ago (2014-05-05 02:04:47 UTC) #1

minux1

please fix a typo in description (it's go.net, not go.tools).

10 years, 11 months ago (2014-05-05 02:52:00 UTC) #2

adg

Oops. done. Thanks. On 4 May 2014 22:51, <minux.ma@gmail.com> wrote: > please fix a typo ...

10 years, 11 months ago (2014-05-05 02:58:34 UTC) #3

adg

10 years, 11 months ago (2014-05-05 04:38:46 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=53130366067a&repo=net ***

go.net/netutil: don't run test on versions of Go prior to 1.3

LGTM=mikioh.mikioh
R=mikioh.mikioh, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/97970045

Expand All Messages | Collapse All Messages