Issue 9781044: cmd/jujud: Prepare agents for using the API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9781044: cmd/jujud: Prepare agents for using the API (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by dimitern

Modified:
10 years, 11 months ago

Reviewers:
mp+165837, thumper

Visibility:
Public.

Description

cmd/jujud: Prepare agents for using the API Change the interface of agents to pass an extra argument stapi *api.State, in addition to the st *state.State one. This is temporary; the state connection will be removed once all the agents are changed to use the API instead of state directly. This CL prepares the agents to use the API connection but the actual connection will be established in a follow-up https://code.launchpad.net/~dimitern/juju-core/047-open-api-connection-agents/+merge/165837 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -9 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/agent.go	View	4 chunks	+11 lines, -5 lines	0 comments	Download
M	cmd/jujud/machine.go	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	cmd/jujud/unit.go	View	3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dimitern

10 years, 11 months ago (2013-05-27 12:34:40 UTC) #3

After a discussion with William, it was decided to go a different path. I
prepared a document to summarize and describe the steps we agreed upon:

https://docs.google.com/a/canonical.com/document/d/1qNSzFUh_r_fnceAUDsIT4SPVJ...

I'm closing this.

Expand All Messages | Collapse All Messages