Issue 97800045: code review 97800045: runtime: fix bug in GOTRACEBACK=crash causing suppressi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 97800045: code review 97800045: runtime: fix bug in GOTRACEBACK=crash causing suppressi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by adonovan

Modified:
11 years ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

runtime: fix bug in GOTRACEBACK=crash causing suppression of core dumps. Because gotraceback is called early and often, its cache commits to the value of getenv("GOTRACEBACK") before getenv is even ready. So now we reset its cache once getenv becomes ready. Panicking programs now dump core again.

Patch Set 1 #

Patch Set 2 : diff -r e91434717f12 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e91434717f12 https://code.google.com/p/go/ #

Patch Set 4 : diff -r afef4a014b0e https://code.google.com/p/go/ #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	src/pkg/runtime/runtime.c	View	1	5 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years ago (2014-04-29 17:19:53 UTC) #1

adonovan

11 years ago (2014-05-02 17:07:06 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=59cef24ed471 ***

runtime: fix bug in GOTRACEBACK=crash causing suppression of core dumps.

Because gotraceback is called early and often, its cache commits to the value of
getenv("GOTRACEBACK") before getenv is even ready.  So now we reset its cache
once getenv becomes ready.  Panicking programs now dump core again.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/97800045

Expand All Messages | Collapse All Messages