Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1230)

Issue 97730043: provider/common: fix time-sensitive test

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by axw
Modified:
9 years, 11 months ago
Reviewers:
mp+216997, jameinel
Visibility:
Public.

Description

provider/common: fix time-sensitive test Test unnecessarily uses a goroutine; we can just prime the "interrupted" channel before calling into WaitSSH. Fixes lp:1282692 https://code.launchpad.net/~axwalk/juju-core/lp1282692-test-bootstrapssh-timesensitive/+merge/216997 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M provider/common/bootstrap_test.go View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 2
axw
Please take a look.
9 years, 11 months ago (2014-04-24 08:28:02 UTC) #1
jameinel
9 years, 11 months ago (2014-04-24 08:51:51 UTC) #2
so this may never actually wait for connecting, right? (it could easily notice
that it was interrupted before it even tried to connect. And the test is at
least theoretically that it notices while it is waiting.

Anyway, LGTM mostly because it makes the test more straightforward.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b