runner: fix possible shutdown deadlocks

runner: fix possible shutdown deadlocks

When the runner was shutting down, it ignored
requests, which could cause deadlocks in some cases.

https://code.launchpad.net/~rogpeppe/juju-core/314-worker-fix-runner-deadlock/+merge/165741

Requires: https://code.launchpad.net/~rogpeppe/juju-core/313-jsoncodec-optional-log/+merge/165736

(do not edit description out of merge proposal)

[rog, 2013-05-25 13:37:14]

Please take a look.

[fwereade, 2013-05-27 20:35:52]

LGTM

https://codereview.appspot.com/9770043/diff/4001/worker/runner.go
File worker/runner.go (right):

https://codereview.appspot.com/9770043/diff/4001/worker/runner.go#newcode60
worker/runner.go:60: // Runner.Wait (non-fatal errors will not be returned from
Wait).
This deserves a sentence, not parens, imo

[thumper, 2013-06-06 04:37:44]

LGTM

https://codereview.appspot.com/9770043/diff/4001/worker/runner.go
File worker/runner.go (right):

https://codereview.appspot.com/9770043/diff/4001/worker/runner.go#newcode154
worker/runner.go:154: log.Infof("worker: runner is dying")
FYI, you could create a package level logger now using:
  var logger = loggo.GetLogger("juju.worker")

Then use
  logger.Info("runner is dying")

As the module is included in the output.

[fwereade, 2013-06-06 16:36:15]

https://codereview.appspot.com/9770043/diff/4001/worker/runner.go
File worker/runner.go (right):

https://codereview.appspot.com/9770043/diff/4001/worker/runner.go#newcode154
worker/runner.go:154: log.Infof("worker: runner is dying")
On 2013/06/06 04:37:44, thumper wrote:
> FYI, you could create a package level logger now using:
>   var logger = loggo.GetLogger("juju.worker")
> 
> Then use
>   logger.Info("runner is dying")
> 
> As the module is included in the output.

+100 :)

[rog, 2013-06-19 08:19:43]

submitting in https://codereview.appspot.com/10401044
as it needs to be re-proposed.

https://codereview.appspot.com/9770043/diff/4001/worker/runner.go
File worker/runner.go (right):

https://codereview.appspot.com/9770043/diff/4001/worker/runner.go#newcode154
worker/runner.go:154: log.Infof("worker: runner is dying")
On 2013/06/06 16:36:15, fwereade wrote:
> On 2013/06/06 04:37:44, thumper wrote:
> > FYI, you could create a package level logger now using:
> >   var logger = loggo.GetLogger("juju.worker")
> > 
> > Then use
> >   logger.Info("runner is dying")
> > 
> > As the module is included in the output.
> 
> +100 :)

i think that probably deserves another CL. we could change loads of stuff in
that way.