code review 9762045: misc/emacs: fix godef-jump on Windows.

misc/emacs: fix godef-jump on Windows.

Fixes issue 5555.

[cpylua, 2013-05-25 03:45:40]

Hello golang-dev@googlegroups.com (cc: dominik.honnef@gmail.com),

I'd like you to review this change to
https://code.google.com/p/go

[Dominik Honnef, 2013-05-25 11:13:58]

Please change the subject to "misc/emacs: ..." instead of "go-mode: ..."

It works fine for me on Unix, I'll take your word it works on Windows. Make the
remaining changes and it should be good to go.

https://codereview.appspot.com/9762045/diff/3002/misc/emacs/go-mode.el
File misc/emacs/go-mode.el (right):

https://codereview.appspot.com/9762045/diff/3002/misc/emacs/go-mode.el#newcod...
misc/emacs/go-mode.el:877: (message "Unexpected godef output: %s" specifier)
Use error here, not message. The arguments can stay the same, error uses a
format string, too.

[gobot, 2013-05-25 17:21:24]

R=adonovan (assigned by r)

[cpylua, 2013-05-26 01:57:22]

On 2013/05/25 11:13:58, Dominik Honnef wrote:
> Please change the subject to "misc/emacs: ..." instead of "go-mode: ..."
> 
> It works fine for me on Unix, I'll take your word it works on Windows. Make
the
> remaining changes and it should be good to go.
> 
> https://codereview.appspot.com/9762045/diff/3002/misc/emacs/go-mode.el
> File misc/emacs/go-mode.el (right):
> 
>
https://codereview.appspot.com/9762045/diff/3002/misc/emacs/go-mode.el#newcod...
> misc/emacs/go-mode.el:877: (message "Unexpected godef output: %s" specifier)
> Use error here, not message. The arguments can stay the same, error uses a
> format string, too.

Thanks for the suggestions.

[Dominik Honnef, 2013-05-26 02:05:55]

LGTM

[cpylua, 2013-05-26 02:08:00]

Use error instead of message if godef output is malformed.

[adonovan, 2013-05-29 16:19:42]

On 2013/05/26 02:08:00, cpylua wrote:
> Use error instead of message if godef output is malformed.

LGTM

Should I submit it?

[Dominik Honnef, 2013-05-29 19:41:28]

On 2013/05/29 16:19:42, adonovan wrote:
> On 2013/05/26 02:08:00, cpylua wrote:
> > Use error instead of message if godef output is malformed.
> 
> LGTM
> 
> Should I submit it?

That'd be great.

[Dominik Honnef, 2013-06-08 13:28:53]

Ping?

[cpylua, 2013-06-08 15:26:41]

On 2013/05/29 16:19:42, adonovan wrote:
> On 2013/05/26 02:08:00, cpylua wrote:
> > Use error instead of message if godef output is malformed.
> 
> LGTM
> 
> Should I submit it?

That would be great.

[Dominik Honnef, 2013-06-25 22:36:04]

Pinging once more. I really don't want to be annoying about CLs to misc/emacs,
but I'd really like to see this merged.

[iant, 2013-06-26 00:14:59]

Have you signed the CLA?

[cpylua, 2013-06-26 05:14:44]

On 2013/06/26 00:14:59, iant wrote:
> Have you signed the CLA?

I signed the CLA form electronically weeks ago, but no response. Is it okay?

[adonovan, 2013-06-26 19:16:51]

On 2013/06/26 05:14:44, cpylua wrote:
> On 2013/06/26 00:14:59, iant wrote:
> > Have you signed the CLA?
> 
> I signed the CLA form electronically weeks ago, but no response. Is it okay?

Sorry for letting this slip---I failed to notice that I was the pingee.
  
"zombie.fml@gmail.com" doesn't appear in CONTRIBUTORS.  You'll need to get that
added before it will let me commit the CL on your behalf.

[iant, 2013-06-26 20:59:28]

*** Submitted as https://code.google.com/p/go/source/detail?r=c96951f239c0 ***

misc/emacs: fix godef-jump on Windows.

Fixes issue 5555.

R=adonovan, dominik.honnef, iant
CC=gobot, golang-dev
https://codereview.appspot.com/9762045

Committer: Ian Lance Taylor <iant@golang.org>

[iant, 2013-06-26 20:59:49]

I took care of this.  Sorry for the delay.