Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3116)

Issue 97570051: state/apiserver: ensure Facades match their type

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by jameinel
Modified:
9 years, 11 months ago
Reviewers:
dimitern, mp+220615
Visibility:
Public.

Description

state/apiserver: ensure Facades match their type FacadeFactory has to be a type defined to return interface{} because of go type limitations. However, when we Register a Facade we define what Type is meant to be exposed in that API. This change makes sure that we enforce that Type at runtime. This change also cleans up srvRoot slightly to reduce its coupling with the rest of the system and make it possible to create one for testing. https://code.launchpad.net/~jameinel/juju-core/api-srvRoot-ensures-type/+merge/220615 Requires: https://code.launchpad.net/~jameinel/juju-core/api-registry-tracks-type/+merge/220588 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -8 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/export_test.go View 2 chunks +18 lines, -0 lines 0 comments Download
M state/apiserver/root.go View 5 chunks +17 lines, -7 lines 0 comments Download
M state/apiserver/root_test.go View 2 chunks +53 lines, -1 line 0 comments Download
M utils/registry/registry.go View 1 chunk +11 lines, -0 lines 0 comments Download
M utils/registry/registry_test.go View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
9 years, 11 months ago (2014-05-22 11:01:06 UTC) #1
dimitern
9 years, 11 months ago (2014-05-22 12:17:28 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b